-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Added attribute filter for skeleton points #9894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TejasMankeshwar
wants to merge
2
commits into
cvat-ai:develop
Choose a base branch
from
TejasMankeshwar:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+70
−16
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -53,6 +53,7 @@ const getAttributesSubfields = (labels: Label[]): Record<string, any> => { | |
| }; | ||
|
|
||
| const labelSubfields = subfields[adjustedLabelName].subfields; | ||
| // Add root label attributes | ||
| label.attributes.forEach((attr: any): void => { | ||
| const adjustedAttrName = adjustName(attr.name); | ||
| labelSubfields[adjustedAttrName] = { | ||
|
|
@@ -68,6 +69,34 @@ const getAttributesSubfields = (labels: Label[]): Record<string, any> => { | |
| }; | ||
| } | ||
| }); | ||
|
|
||
| // If skeleton, add sublabel (point) attributes as nested fields | ||
| if (label.type === 'skeleton' && Array.isArray(label.sublabels)) { | ||
| label.sublabels.forEach((sublabel: any) => { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Need to add type |
||
| const adjustedSublabelName = adjustName(sublabel.name); | ||
| labelSubfields[adjustedSublabelName] = { | ||
| type: '!struct', | ||
| label: sublabel.name, | ||
| subfields: {}, | ||
| }; | ||
| const sublabelSubfields = labelSubfields[adjustedSublabelName].subfields; | ||
| sublabel.attributes.forEach((attr: any) => { | ||
| const adjustedAttrName = adjustName(attr.name); | ||
| sublabelSubfields[adjustedAttrName] = { | ||
| label: attr.name, | ||
| type: getConvertedInputType(attr.inputType), | ||
| }; | ||
| if (sublabelSubfields[adjustedAttrName].type === 'select') { | ||
| sublabelSubfields[adjustedAttrName] = { | ||
| ...sublabelSubfields[adjustedAttrName], | ||
| fieldSettings: { | ||
| listValues: attr.values, | ||
| }, | ||
| }; | ||
| } | ||
| }); | ||
| }); | ||
| } | ||
| }); | ||
|
|
||
| return subfields; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,26 +2,51 @@ | |
| // | ||
| // SPDX-License-Identifier: MIT | ||
|
|
||
|
|
||
| import React from 'react'; | ||
| import Result from 'antd/lib/result'; | ||
| import Button from 'antd/lib/button'; | ||
| import { useHistory } from 'react-router'; | ||
|
|
||
| export const JobNotFoundComponent = React.memo((): JSX.Element => ( | ||
| <Result | ||
| className='cvat-not-found' | ||
| status='404' | ||
| title='Sorry, but this job was not found' | ||
| subTitle='Please, be sure information you tried to get exist and you have access' | ||
| /> | ||
| )); | ||
| export const JobNotFoundComponent = React.memo((): JSX.Element => { | ||
| const history = useHistory(); | ||
| const handleGoToJobs = () => { | ||
| history.push('/jobs'); | ||
| }; | ||
| return ( | ||
| <Result | ||
| className='cvat-not-found' | ||
| status='404' | ||
| title='Sorry, but this job was not found' | ||
| subTitle='Please, be sure information you tried to get exist and you have access' | ||
| extra={ | ||
| <Button type='primary' onClick={handleGoToJobs}> | ||
| Go to Jobs (reset filters) | ||
| </Button> | ||
| } | ||
| /> | ||
| ); | ||
| }); | ||
|
Comment on lines
+11
to
+29
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be covered in #10028 with other not found components, I suggest to remove it |
||
|
|
||
| export const TaskNotFoundComponent = React.memo((): JSX.Element => ( | ||
| <Result | ||
| className='cvat-not-found' | ||
| status='404' | ||
| title='There was something wrong during getting the task' | ||
| subTitle='Please, be sure, that information you tried to get exist and you are eligible to access it' | ||
| /> | ||
| )); | ||
| export const TaskNotFoundComponent = React.memo((): JSX.Element => { | ||
| const history = useHistory(); | ||
| const handleGoToTasks = () => { | ||
| history.push('/tasks'); | ||
| }; | ||
| return ( | ||
| <Result | ||
| className='cvat-not-found' | ||
| status='404' | ||
| title='There was something wrong during getting the task' | ||
| subTitle='Please, be sure, that information you tried to get exist and you are eligible to access it' | ||
| extra={ | ||
| <Button type='primary' onClick={handleGoToTasks}> | ||
| Go to Tasks (reset filters) | ||
| </Button> | ||
| } | ||
| /> | ||
| ); | ||
| }); | ||
|
|
||
| export const ProjectNotFoundComponent = React.memo((): JSX.Element => ( | ||
| <Result | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.