Skip to content

Conversation

@jyameo
Copy link
Contributor

@jyameo jyameo commented Dec 22, 2025

Refactor HotReloadResponse to eliminate the dependency on package:built_value by using standard Dart JSON serialization instead.

Changes

  • Rewrote HotReloadResponse as a simple Dart class with manual JSON serialization
  • Replaced builder pattern constructor with standard named parameter constructor
  • Implemented fromJson() factory and toJson() method for JSON serialization
  • Maps JSON 'error' field to errorMessage property for clarity
  • Removed HotReloadResponse from built_value serializers annotation
  • Updated usage in client.dart to use new constructor syntax via the updated _sendResponse() pattern

Testing

Existing tests for hot reload functionality continue to pass with the updated implementation.

Fixes dart-lang/sdk#62289

@jyameo jyameo requested review from biggs0125 and srujzs December 22, 2025 19:15
Copy link
Contributor

@biggs0125 biggs0125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jyameo jyameo merged commit 9cde477 into dart-lang:main Dec 22, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove built_value dependency from HotReloadResponse

2 participants