Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dwds/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## 26.2.4-wip

- Remove `package:built_value` dependency from `HotReloadRequest` and use standard Dart JSON serialization instead.
- Remove `package:built_value` dependency from `HotReloadRequest`,`HotReloadResponse` and use standard Dart JSON serialization instead.

## 26.2.3

Expand Down
59 changes: 41 additions & 18 deletions dwds/lib/data/hot_reload_response.dart
Original file line number Diff line number Diff line change
Expand Up @@ -4,28 +4,51 @@

library hot_reload_response;

import 'package:built_value/built_value.dart';
import 'package:built_value/serializer.dart';

part 'hot_reload_response.g.dart';

/// A response to a hot reload request.
abstract class HotReloadResponse
implements Built<HotReloadResponse, HotReloadResponseBuilder> {
static Serializer<HotReloadResponse> get serializer =>
_$hotReloadResponseSerializer;

class HotReloadResponse {
/// The unique identifier matching the request.
String get id;
final String id;

/// Whether the hot reload succeeded on the client.
bool get success;
final bool success;

/// An optional error message if success is false.
@BuiltValueField(wireName: 'error')
String? get errorMessage;

HotReloadResponse._();
factory HotReloadResponse([void Function(HotReloadResponseBuilder) updates]) =
_$HotReloadResponse;
final String? errorMessage;

HotReloadResponse({
required this.id,
required this.success,
this.errorMessage,
});

/// Creates a [HotReloadResponse] from a JSON map.
factory HotReloadResponse.fromJson(Map<String, dynamic> json) {
return HotReloadResponse(
id: json['id'] as String,
success: json['success'] as bool,
errorMessage: json['error'] as String?,
);
}

/// Converts this [HotReloadResponse] to a JSON map.
Map<String, dynamic> toJson() => {
'id': id,
'success': success,
if (errorMessage != null) 'error': errorMessage,
};

@override
bool operator ==(Object other) =>
identical(other, this) ||
other is HotReloadResponse &&
id == other.id &&
success == other.success &&
errorMessage == other.errorMessage;

@override
int get hashCode => Object.hash(id, success, errorMessage);

@override
String toString() =>
'HotReloadResponse(id: $id, success: $success, errorMessage: $errorMessage)';
}
208 changes: 0 additions & 208 deletions dwds/lib/data/hot_reload_response.g.dart

This file was deleted.

2 changes: 0 additions & 2 deletions dwds/lib/data/serializers.dart
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import 'debug_info.dart';
import 'devtools_request.dart';
import 'error_response.dart';
import 'extension_request.dart';
import 'hot_reload_response.dart';
import 'hot_restart_request.dart';
import 'hot_restart_response.dart';
import 'service_extension_request.dart';
Expand All @@ -33,7 +32,6 @@ part 'serializers.g.dart';
DebugInfo,
DevToolsRequest,
DevToolsResponse,
HotReloadResponse,
HotRestartRequest,
HotRestartResponse,
IsolateExit,
Expand Down
1 change: 0 additions & 1 deletion dwds/lib/data/serializers.g.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading