Repository navigation
Cover Scala 3 core gaps (formats, Seq, empty struct, summoner) - #661
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #661 +/- ##
==========================================
+ Coverage 88.77% 91.33% +2.55%
==========================================
Files 32 32
Lines 508 508
Branches 55 62 +7
==========================================
+ Hits 451 464 +13
+ Misses 57 44 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scala 3 coverage jobs measure core's scala_3 sources for the first time and report uncovered lines there (local core statement coverage was 75.58%). This adds the missing tests in the existing AnyFlatSpec/Matchers style: a FormatsSpec (default/snakify/key-type transforms), plus Seq conversion, empty-struct derivation and the SqlInstanceConversion summoner. Local core coverage on 3.3.3 is now 100% statement and branch.