-
Notifications
You must be signed in to change notification settings - Fork 5.8k
chore: try to fix promote_to_release workflow #31215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dsherret
wants to merge
1
commit into
denoland:main
Choose a base branch
from
dsherret:chore_update_patchver
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,20 +46,8 @@ jobs: | |
| Expand-Archive -Path "denort-windows.zip" -DestinationPath "." | ||
|
|
||
| - name: Run patchver for Windows | ||
| shell: pwsh | ||
| run: | | ||
| deno install -g -A -n patchver https://deno.land/x/[email protected]/cli.ts | ||
| $CHANNEL="${{github.event.inputs.releaseKind}}" | ||
| # Patch deno.exe | ||
| Move-Item -Path "deno.exe" -Destination "deno_original.exe" | ||
| patchver "deno_original.exe" "deno.exe" $CHANNEL | ||
| # Patch denort.exe | ||
| Move-Item -Path "denort.exe" -Destination "denort_original.exe" | ||
| patchver "denort_original.exe" "denort.exe" $CHANNEL | ||
|
|
||
| # Rename files to match expected pattern | ||
| Move-Item -Path "deno.exe" -Destination "deno-x86_64-pc-windows-msvc-$CHANNEL.exe" | ||
| Move-Item -Path "denort.exe" -Destination "denort-x86_64-pc-windows-msvc-$CHANNEL.exe" | ||
| deno run -A ./tools/release/promote_to_release_windows.ts ${{github.event.inputs.releaseKind}} | ||
|
|
||
| - name: Authenticate with Azure | ||
| uses: azure/login@v1 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ | |
|
|
||
| import { $ } from "jsr:@david/[email protected]"; | ||
| import { gray } from "jsr:@std/fmt@1/colors"; | ||
| import { patchver } from "jsr:@deno/patchver@0.2.0"; | ||
| import { patchver } from "jsr:@deno/patchver@0.3.0"; | ||
|
|
||
| const SUPPORTED_TARGETS = [ | ||
| "aarch64-apple-darwin", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| #!/usr/bin/env -S deno run -A | ||
| // Copyright 2018-2025 the Deno authors. MIT license. | ||
|
|
||
| // deno-lint-ignore-file no-console | ||
|
|
||
| import { patchver } from "jsr:@deno/[email protected]"; | ||
|
|
||
| const CHANNEL = Deno.args[0]; | ||
| if (CHANNEL !== "rc" && CHANNEL !== "lts") { | ||
| throw new Error(`Invalid channel: ${CHANNEL}`); | ||
| } | ||
|
|
||
| const BINARIES = ["deno.exe", "denort.exe"]; | ||
|
|
||
| async function patchBinary(inputPath: string, channel: string) { | ||
| console.log(`Patching ${inputPath}...`); | ||
|
|
||
| const input = await Deno.readFile(inputPath); | ||
| const output = patchver(input, channel); | ||
|
|
||
| // Extract filename without extension and create output name | ||
| const baseName = inputPath.replace(/\.exe$/, ""); | ||
| const outputPath = `${baseName}-x86_64-pc-windows-msvc-${channel}.exe`; | ||
|
|
||
| await Deno.writeFile(outputPath, output); | ||
| console.log(`Created ${outputPath}`); | ||
| } | ||
|
|
||
| async function main() { | ||
| for (const binary of BINARIES) { | ||
| await patchBinary(binary, CHANNEL); | ||
| } | ||
| console.log("All Windows binaries patched successfully!"); | ||
| } | ||
|
|
||
| await main(); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patchBinary function lacks error handling for file operations. In the existing promote_to_release.ts script, similar operations wrap file writes in try-catch blocks (lines 122-130) and exit with error messages on failure. Consider adding similar error handling here to provide clear feedback when file operations fail.