Test tools with MODEL=32 too #164
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for your pull request, @wilzbach! |
WebDrake
reviewed
Feb 4, 2018
vars/runPipeline.groovy
Outdated
| // test 32-bit build of the D tools | ||
| sh "make -f posix.mak clean" | ||
| sh "make -f posix.mak all MODEL=32 DMD='${env.WORKSPACE}/distribution/bin/dmd'" | ||
| sh "make -f posix.mak test MODEL=32 DMD='${env.WORKSPACE}/distribution/bin/dmd' DFLAGS=" |
There was a problem hiding this comment.
Is there a reason for not explicitly marking the existing tests with MODEL=64 ... ? Or is the assumption that the setup as written will be more robust to being run in both 32- and 64-bit host environments?
wilzbach
force-pushed
the
tools-32
branch
2 times, most recently
from
e6606b0 to
87bb55a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also: dlang/tools#304