Skip to content

Conversation

@WebDrake
Copy link
Contributor

@WebDrake WebDrake commented Feb 4, 2018

For some reason 32-bit builds are only tested for stable dmd. This seems an oversight: we don't want to find out that the D tools break 32-bit dmd only after a stable release has come out!

This patch therefore adds an extra Travis build with DMD=dmd-nightly and MODEL=32.

For some reason 32-bit builds are only tested for stable `dmd`.  This
seems an oversight: we don't want to find out that the D tools break
32-bit `dmd` only after a stable release has come out!

This patch therefore adds an extra Travis build with `DMD=dmd-nightly`
and `MODEL=32`.
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WebDrake! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@WebDrake
Copy link
Contributor Author

WebDrake commented Feb 4, 2018

Just as a note: the extra packages required suggest that we're testing these 32-bit builds solely on 64-bit systems. Is that intended?

@wilzbach
Copy link
Contributor

wilzbach commented Feb 4, 2018

we don't want to find out that the D tools break 32-bit dmd only after a stable release has come out!

Then you should add it here:

https://github.com/dlang/ci/blob/master/vars/runPipeline.groovy#L251

No one looks at the CI results of the cron jobs. Well, I do get mails, but I also have a life from time to time.

Just as a note: the extra packages required suggest that we're testing these 32-bit builds solely on 64-bit systems. Is that intended?

There's almost no 32-bit hardware anymore. 32-bit is entirely legacy. My Linux distro even dropped the support half a year ago.

@WebDrake
Copy link
Contributor Author

WebDrake commented Feb 4, 2018

Then you should add it here:

I don't quite follow what you want changed ... ?

@WebDrake
Copy link
Contributor Author

WebDrake commented Feb 4, 2018

There's almost no 32-bit hardware anymore. 32-bit is entirely legacy. My Linux distro even dropped the support half a year ago.

There are still distros targeting 32-bit architectures, and DMD and its tools are designed to work in 32-bit builds. (I build i386 snap packages, for example.)

Dropping 32-bit support needs to be a conscious policy decision, not something that happens de-facto due to lack of test coverage.

@wilzbach
Copy link
Contributor

wilzbach commented Feb 4, 2018

I don't quite follow what you want changed ... ?

I don't want anything changed, I'm happy to merge this.
I just told you that adding it here to the CI won't prevent regression (what the motivation of this was) per se, because it's not run on PRs at dmd/druntime/phobos, but dlang/ci is.

(Though OTOH it's very unlikely that the 32-bit codegen at DMD changes without the other testsuites catching it)

@wilzbach wilzbach merged commit c56a2c6 into dlang:master Feb 4, 2018
@WebDrake
Copy link
Contributor Author

WebDrake commented Feb 4, 2018

I just told you that adding it here to the CI won't prevent regression (what the motivation of this was) per se, because it's not run on PRs at dmd/druntime/phobos, but dlang/ci is.

Right. I still don't understand what needs to be changed on the dlang/ci side of things, though ;-)

@WebDrake WebDrake deleted the travis-dmd-nightly-32 branch February 4, 2018 18:31
@wilzbach
Copy link
Contributor

wilzbach commented Feb 4, 2018

Something like this: dlang/ci#164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants