-
-
Notifications
You must be signed in to change notification settings - Fork 146
Add 32-bit dmd-nightly builds to Travis CI #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For some reason 32-bit builds are only tested for stable `dmd`. This seems an oversight: we don't want to find out that the D tools break 32-bit `dmd` only after a stable release has come out! This patch therefore adds an extra Travis build with `DMD=dmd-nightly` and `MODEL=32`.
|
Thanks for your pull request, @WebDrake! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Some tips to help speed things up:
Bear in mind that large or tricky changes may require multiple rounds of review and revision. Please see CONTRIBUTING.md for more information. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
|
Just as a note: the extra packages required suggest that we're testing these 32-bit builds solely on 64-bit systems. Is that intended? |
Then you should add it here: https://github.com/dlang/ci/blob/master/vars/runPipeline.groovy#L251 No one looks at the CI results of the cron jobs. Well, I do get mails, but I also have a life from time to time.
There's almost no 32-bit hardware anymore. 32-bit is entirely legacy. My Linux distro even dropped the support half a year ago. |
I don't quite follow what you want changed ... ? |
There are still distros targeting 32-bit architectures, and DMD and its tools are designed to work in 32-bit builds. (I build i386 snap packages, for example.) Dropping 32-bit support needs to be a conscious policy decision, not something that happens de-facto due to lack of test coverage. |
I don't want anything changed, I'm happy to merge this. (Though OTOH it's very unlikely that the 32-bit codegen at DMD changes without the other testsuites catching it) |
Right. I still don't understand what needs to be changed on the dlang/ci side of things, though ;-) |
|
Something like this: dlang/ci#164 |
For some reason 32-bit builds are only tested for stable
dmd. This seems an oversight: we don't want to find out that the D tools break 32-bitdmdonly after a stable release has come out!This patch therefore adds an extra Travis build with
DMD=dmd-nightlyandMODEL=32.