Skip to content

Conversation

@lvarin
Copy link
Contributor

@lvarin lvarin commented Dec 22, 2023

… 5 months ago

IMPORTANT: Please create an issue before filing a pull request! Changes need to be discussed before proceeding. Please read the contribution guidelines.

Details

Please provide enough information so that others can review your pull request. Give a brief summary of the motivation. Refer to the corresponding issue/s with #XXXX for more information.

Testing

Write the appropriate unit and integration tests, if applicable. Make sure these and all other tests pass.

Documentation

Please document your changes and test cases in the appropriate places, if applicable.

Style

Make sure your changes adhere to the coding/documentation style used throughout the project.

Closing issues

If your changes fix any issue/s, put closes #XXXX in your comment to auto-close it/them.

Credit

Add your credentials to the list of contributors once your pull request was merged.

@lvarin lvarin force-pushed the upgrade-python-3.8 branch from 7639f63 to 2e4be97 Compare December 22, 2023 12:46
@lvarin lvarin force-pushed the upgrade-python-3.8 branch from 5783f20 to 08efbbc Compare December 22, 2023 13:29
@uniqueg
Copy link
Member

uniqueg commented Dec 24, 2023

This will be fixed by @kushagra189 soon. In fact, I recommend upgrading to at least py3.10 - given that py3.8 end of life will be in 2024 and FOCA was recently upgraded to support py3.11 (not released yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants