Update Helm Chart #121
Open
Update Helm Chart #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update mongodb image - Add init-script js - Update OKD Route/Ingress condition - Add resources
Reviewer's GuideThis PR enhances the Helm chart by introducing a unified ingress toggle for OKD Route or Kubernetes Ingress, adding resource requests/limits, updating MongoDB configuration and image, and embedding an initialization script to bootstrap MongoDB collections. Entity relationship diagram for MongoDB collections initialized by init-scripterDiagram
TOOLS {
string id PK
}
SERVICE_INFO {
string id PK
}
TOOLCLASSES {
string id PK
}
TOOLS ||--|| SERVICE_INFO : "related"
TOOLS ||--|| TOOLCLASSES : "classified by"
Class diagram for updated Helm values structureclassDiagram
class TrsFiler {
+string image
+string appName
+Ingress ingress
+Resources resources
}
class Ingress {
+bool enabled
+Https https
}
class Https {
+bool enabled
+string issuer
}
class Resources {
+string cpu
+string memory
}
class MongoDB {
+string image
+string dbName
+string volumeSize
+Resources resources
}
TrsFiler o-- Ingress
Ingress o-- Https
TrsFiler o-- Resources
MongoDB o-- Resources
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #121 +/- ##
=======================================
Coverage 92.93% 92.93%
=======================================
Files 12 12
Lines 623 623
=======================================
Hits 579 579
Misses 44 44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `deployment/templates/mongo-init-script.yaml:14` </location>
<code_context>
+
+ // Create the 'tools', 'service_info' and 'toolclasses' collections
+ // Database configuration from https://github.com/elixir-cloud-aai/trs-filer/blob/9116b702bce2ef5b2e04130a6fe5db2a89d465f3/trs_filer/config.yaml#L9
+ db.createCollection('tools');
+ db.tools.createIndex(
+ { id: 1 },
</code_context>
<issue_to_address>
**issue (bug_risk):** Repeated collection/index creation may cause errors if collections already exist.
Consider adding checks to ensure collections and indexes are only created if they do not already exist, or handle errors to prevent failures on repeated deployments.
</issue_to_address>
### Comment 2
<location> `deployment/templates/trs-filer-ingress.yaml:18` </location>
<code_context>
+ http:
+ paths:
+ - path: /
+ pathType: prefix
+ backend:
+ service:
</code_context>
<issue_to_address>
**issue (bug_risk):** Ingress pathType should be 'Prefix' (capitalized) for Kubernetes compatibility.
Update pathType to 'Prefix' to avoid validation errors and ensure compatibility with Kubernetes.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
|
||
| // Create the 'tools', 'service_info' and 'toolclasses' collections | ||
| // Database configuration from https://github.com/elixir-cloud-aai/trs-filer/blob/9116b702bce2ef5b2e04130a6fe5db2a89d465f3/trs_filer/config.yaml#L9 | ||
| db.createCollection('tools'); |
There was a problem hiding this comment.
issue (bug_risk): Repeated collection/index creation may cause errors if collections already exist.
Consider adding checks to ensure collections and indexes are only created if they do not already exist, or handle errors to prevent failures on repeated deployments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Checklist:
Summary by Sourcery
Improve Helm chart by making ingress behavior configurable, adding resource limits, introducing a MongoDB init script, and enabling dynamic database naming.
New Features:
Enhancements: