chore(ci): remove pulumi-java-gen now that it is unsupported #311
Conversation
Does the PR have any schema changes?Does the PR have any schema changes?Looking good! No breaking changes found. New functions:
Maintainer note: consult the runbook for dealing with any breaking changes. |
| module equinix-fabric-connection-example_fcr_to_network | ||
|
|
||
| go 1.22.0 | ||
| go 1.23 |
There was a problem hiding this comment.
If we can get away with updating examples later, it'd probably be a good idea to revert these changes since this PR is huge.
| import com.pulumi.equinix.metal.ProjectSshKeyArgs; | ||
| import com.pulumi.equinix.metal.Device; | ||
| import com.pulumi.equinix.metal.DeviceArgs; | ||
| import com.equinix.equinix.metal.ProjectSshKey; |
There was a problem hiding this comment.
The old docs were wrong, but so are the new ones. To keep this PR small, I'm tempted to use sed to inject the old, wrong package to avoid this diff for now and then update sed to inject the new, correct package in a later PR.
| import com.pulumi.core.Output; | ||
| import com.pulumi.equinix.fabric.CloudRouter; | ||
| import com.pulumi.equinix.fabric.CloudRouterArgs; | ||
| import com.equinix.equinix.fabric.CloudRouter; |
There was a problem hiding this comment.
As with docs, the old and new packages here are both wrong, but it might be better to restore the old wrong value to keep the diff small and then fix it later.
ctreatma
force-pushed
the
fix-upgrade-provider-action
branch
from
bb22ef0 to
86f74aa
Compare
|
| import com.equinix.pulumi.equinix.fabric.CloudRouter; | ||
| import com.equinix.pulumi.equinix.fabric.CloudRouterArgs; |
There was a problem hiding this comment.
It looks like the change to basePackage in #318 doesn't have an effect on import paths in Java examples until we switch to the bridge-provided Java generator. That's fine, just worth keeping in mind that this chain of PRs is working towards consistency & accuracy and we may not be in a completely stable state until we're fully caught up with broader Pulumi CI standards.
| "name": "equinix-fabric-cloud_router-example_2", | ||
| "devDependencies": { | ||
| "@types/node": "^14" | ||
| "@types/node": "^18" |
There was a problem hiding this comment.
There are some minor changes to Go and JavaScript examples included in this PR. Unfortunately I can't break these out because upgrading the provider bridge without dropping pulumi-java-gen causes make build_java to fail.
ctreatma
force-pushed
the
stop-patching-java
branch
2 times, most recently
from
7e80af1 to
4d3074c
Compare
ctreatma
force-pushed
the
fix-upgrade-provider-action
branch
from
86f74aa to
53106af
Compare
Provider upgrades are failing again. Java code generation was moved into the Pulumi-Terraform bridge and now provider upgrades are failing because the
upgrade-providerCLI no longer has a--java-versionoption. It's possible we could lockupgrade-providerto a known good commit (there are no releases or tags in our CI instead of droppingpulumi-java-gen, but that will likely lead to even more work down the road as we drift further from the intended maintenance workflow.Long-term, we need to reconsider how we maintain this provider. We are using workflows and tools that are not intended for use outside of Pulumi and will continue to run into these sorts of breakages.