Reuse the gen-source-db discovery machinery for run-tree#6
Closed
msullivan wants to merge 4 commits intofacebook:mainfrom
Closed
Reuse the gen-source-db discovery machinery for run-tree#6msullivan wants to merge 4 commits intofacebook:mainfrom
msullivan wants to merge 4 commits intofacebook:mainfrom
Conversation
I'm not totally sure if you want this, but it will let me start using run-tree instead of doing a separate gen-source-db + run step. In addition to reducing duplication, this gives run-tree access to site-packages.
msullivan
force-pushed
the
only-gen_source_db
branch
from
661e0e7 to
1b49cf0
Compare
|
@brittanyrey has imported this pull request. If you are a Meta employee, you can view this in D101821013. |
martindemello
requested changes
Apr 21, 2026
martindemello
requested changes
Apr 21, 2026
Contributor
martindemello
left a comment
martindemello
left a comment
There was a problem hiding this comment.
i won't block this PR on it, but we should think about adding a test framework with an in-memory file system or something so we can test all this.
brittanyrey
approved these changes
Apr 21, 2026
|
@martindemello merged this pull request in ce8bab2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not totally sure if you want this, but it will let me start using
run-tree instead of doing a separate gen-source-db + run step.
In addition to reducing duplication, this gives run-tree access to
site-packages.