[RN][iOS] Improve Swift support for 3rd party libs#42075
Merged
lunaleaps merged 1 commit into0.72-stablefrom Feb 16, 2024
Merged
[RN][iOS] Improve Swift support for 3rd party libs#42075lunaleaps merged 1 commit into0.72-stablefrom
lunaleaps merged 1 commit into0.72-stablefrom
Conversation
Contributor
|
@cipolleschi I see 0.72.9 was releases recently, but this change wasn't included in release... Any information whether it'll be included in 0.72.10 or not? 👀 |
Contributor
Author
|
yeah, it will likely be included. We had to rush 0.72.9 because the iOS build pipeline was failing for the whole ecosyste due to More info here: #42180 .10 will hopefully be a normal patch, with all the picks. |
Contributor
|
Got it @cipolleschi Thank you for your detailed explanation! |
1 task
This was referenced Feb 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
We are suggesting and migrating 3rd party libs to use
install_modules_dependenciesin their podspecs.However, when some of those libs uses Swift, they become incompatible with some of the pods we expose because we forgot to define modules in those libraries.
With these changes, they would be able to be installed correctly in a 0.72 react Native app.
Changelog:
[Internal] - Improve Swift support by defining modules in React-Fabric, React-graphics, React-utils and React-debug.
Test Plan:
Tested locally by running:
⌘ + B
Observe the app failing to build.
Apply these changes:
⌘ + B
Observer the app build successfully