Skip to content

userspace: Make Cflags in our .pc files more strict #2691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2025
Merged

userspace: Make Cflags in our .pc files more strict #2691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be37a1c
refactor(userspace): Make Cflags in our .pc files more strict
geraldcombs Oct 14, 2025
aeff7a0
update(userspace): Add "License" properties to our .pc files
geraldcombs Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions userspace/libpman/libpman.pc.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ includedir=${prefix}/@CMAKE_INSTALL_INCLUDEDIR@
Name: libpman
Description: Utility library for BPF probes
Version: @FALCOSECURITY_LIBS_VERSION@
License: Apache-2.0

Requires: libbpf zlib
Libs: -L${libdir} -lpman -lscap_event_schema -lscap_platform
Expand Down
3 changes: 2 additions & 1 deletion userspace/libscap/libscap.pc.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@ includedir=${prefix}/@CMAKE_INSTALL_INCLUDEDIR@/@LIBS_PACKAGE_NAME@
Name: libscap
Description: lib for System CAPture
Version: @FALCOSECURITY_LIBS_VERSION@
License: Apache-2.0

Requires: @LIBSCAP_PKGCONFIG_REQUIRES@
Requires.private: @LIBSCAP_PKGCONFIG_REQUIRES_PRIVATE@
Libs: -L${libdir} @LIBSCAP_LINK_LIBDIRS_FLAGS@ @LIBSCAP_LINK_LIBRARIES_FLAGS@
Cflags: -I${includedir} -I${includedir}/libscap -I${includedir}/driver
Cflags: -I${includedir}
2 changes: 1 addition & 1 deletion userspace/libsinsp/fdinfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ limitations under the License.

#include <unordered_map>
#include <memory>
#include <packed_data.h>
#include <libsinsp/packed_data.h>

// fd type characters
#define CHAR_FD_FILE 'f'
Expand Down
3 changes: 2 additions & 1 deletion userspace/libsinsp/libsinsp.pc.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@ includedir=${prefix}/@CMAKE_INSTALL_INCLUDEDIR@/@LIBS_PACKAGE_NAME@
Name: libsinsp
Description: lib for System INSPection
Version: @FALCOSECURITY_LIBS_VERSION@
License: Apache-2.0

Requires: libscap @LIBSINSP_REQUIRES@
Requires.private: @LIBSINSP_REQUIRES_PRIVATE@
Libs: -L${libdir} @SINSP_PKG_CONFIG_LIBDIRS@ @SINSP_PKG_CONFIG_LIBS@
Cflags: -I${includedir} -I${includedir}/libsinsp -I${includedir}/driver @SINSP_PKG_CONFIG_INCLUDES@
Cflags: -I${includedir} @SINSP_PKG_CONFIG_INCLUDES@
2 changes: 1 addition & 1 deletion userspace/libsinsp/threadinfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ struct iovec {

#include <functional>
#include <memory>
#include <sinsp_fdtable_factory.h>
#include <libsinsp/sinsp_fdtable_factory.h>
#include <libsinsp/fdtable.h>
#include <libsinsp/thread_group_info.h>
#include <libsinsp/state/table.h>
Expand Down
Loading