userspace: Make Cflags in our .pc files more strict #2691
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2691 +/- ##
=======================================
Coverage 76.91% 76.91%
=======================================
Files 294 294
Lines 30862 30862
Branches 4689 4689
=======================================
Hits 23739 23739
Misses 7123 7123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
geraldcombs
force-pushed
the
pkg-config-strict-includes
branch
2 times, most recently
from
bb8d87c to
46cd00d
Compare
If it breaks anything, that'd be |
Thanks for catching that. Corresponding PR in draios/sysdig#2166. |
|
/milestone 0.23.0 |
|
Hey @geraldcombs , thank you for the contribution! Changes look good, but could you please adjust the commit heading to match the conventional commit style? I guess it would be something like |
geraldcombs
force-pushed
the
pkg-config-strict-includes
branch
from
46cd00d to
0336274
Compare
Done! |
Remove "-I${includedir}/libscap -I${includedir}/driver" from libscap.pc
and libsinsp.pc. This means that consumers must use prefixed include
paths, such as "#include <libscap/scap.h>" instead of "#include
<scap.h>". However, those include directories contain several generic
filenames such as settings.h, logger.h, plugin.h, user.h, and utils.h,
and this reduces the risk of someone inadvertently including the wrong
file.
Signed-off-by: Gerald Combs <[email protected]>
geraldcombs
force-pushed
the
pkg-config-strict-includes
branch
from
0336274 to
be37a1c
Compare
pkgconf supports a License property, which seems like a useful thing to have. Signed-off-by: Gerald Combs <[email protected]>
|
LGTM label has been added. Git tree hash: 81c2031fe945303180385d5f5269e41204915927
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekoops, geraldcombs, terror96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
Remove "-I${includedir}/libscap -I${includedir}/driver" from libscap.pc and libsinsp.pc. This means that consumers must use prefixed include paths, such as "#include <libscap/scap.h>" instead of "#include <scap.h>". However, those include directories contain several generic filenames such as settings.h, logger.h, plugin.h, user.h, and utils.h, and this reduces the risk of someone inadvertently including the wrong file.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This hopefully helps us avoid a situation like the following: https://gitlab.com/wireshark/wireshark/-/issues/17192
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: