Skip to content

Conversation

@rcaril
Copy link
Contributor

@rcaril rcaril commented Nov 3, 2025

Change summary

This PR removes a test for domain v1 service links that was having issues with 'import' functions. The same coverage still exists now with the now renamed 'TestAccFastlyDomainV1ServiceLink_Basic' test.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?
  • Post the output of your test runs

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@rcaril rcaril requested a review from a team as a code owner November 3, 2025 19:39
@rcaril rcaril requested a review from philippschulte November 3, 2025 19:39
@rcaril
Copy link
Contributor Author

rcaril commented Nov 3, 2025

Test:

=== RUN   TestAccFastlyDomainV1ServiceLink_Basic
=== PAUSE TestAccFastlyDomainV1ServiceLink_Basic
=== CONT  TestAccFastlyDomainV1ServiceLink_Basic
--- PASS: TestAccFastlyDomainV1ServiceLink_Basic (4.82s)
PASS

@rcaril rcaril added the Skip-Changelog Skip changelog build check label Nov 3, 2025
Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rcaril rcaril merged commit fe028de into main Nov 5, 2025
15 checks passed
@rcaril rcaril deleted the rcaril/CDTOOL-1206-fix-domain-service-link-test branch November 5, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip-Changelog Skip changelog build check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants