Skip to content

[CDTOOL-1206] Correct 'TestAccFastlyDomainV1ServiceLink' Test #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 5, 2025
Merged

[CDTOOL-1206] Correct 'TestAccFastlyDomainV1ServiceLink' Test #1137

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ef5bc2
updated test
rcaril Nov 3, 2025
dd2e7fe
Merge branch 'main' into rcaril/CDTOOL-1206-fix-domain-service-link-test
rcaril Nov 3, 2025
997da09
Merge branch 'main' into rcaril/CDTOOL-1206-fix-domain-service-link-test
rcaril Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 2 additions & 53 deletions fastly/resource_fastly_domain_v1_service_link_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,61 +18,10 @@ const (
serviceID2 = "iWBciPXoEl8PfUOW2hvIm4"
)

func TestAccFastlyDomainV1ServiceLink_Basic(t *testing.T) {
resource.ParallelTest(t, resource.TestCase{
PreCheck: func() {
testAccPreCheck(t)
},
ProviderFactories: testAccProviders,
CheckDestroy: testAccCheckDomainV1ServiceLinkDestroy,
Steps: []resource.TestStep{
{
Config: fmt.Sprintf(`
import {
to = fastly_domain_v1_service_link.example
id = "%s"
}

resource "fastly_domain_v1_service_link" "example" {
domain_id = "%s"
service_id = "%s"
}
`, domainID, domainID, serviceID),
Check: resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttr("fastly_domain_v1_service_link.example", "domain_id", domainID),
resource.TestCheckResourceAttr("fastly_domain_v1_service_link.example", "service_id", serviceID),
),
},
{
Config: fmt.Sprintf(`
import {
to = fastly_domain_v1_service_link.example
id = "%s"
}

resource "fastly_domain_v1_service_link" "example" {
domain_id = "%s"
service_id = "%s"
}
`, domainID, domainID, serviceID2),
Check: resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttr("fastly_domain_v1_service_link.example", "domain_id", domainID),
resource.TestCheckResourceAttr("fastly_domain_v1_service_link.example", "service_id", serviceID2),
),
},
{
ResourceName: "fastly_domain_v1_service_link.example",
ImportState: true,
ImportStateVerify: true,
},
},
})
}

// TestAccFastlyDomainV1ServiceLink_Create tests resource creation from scratch (without import).
// TestAccFastlyDomainV1ServiceLink_Basic tests resource creation from scratch (without import).
// This ensures the Create → Read flow works correctly, as import can mask certain behaviors where
// setting d.Id() before Read is called [CDTOOL-1198].
func TestAccFastlyDomainV1ServiceLink_Create(t *testing.T) {
func TestAccFastlyDomainV1ServiceLink_Basic(t *testing.T) {
resource.ParallelTest(t, resource.TestCase{
PreCheck: func() {
testAccPreCheck(t)
Expand Down
Loading