fix(cli): fix remote generation polling hang after task completion#16764
Open
Swimburger wants to merge 1 commit into
Open
fix(cli): fix remote generation polling hang after task completion#16764Swimburger wants to merge 1 commit into
Swimburger wants to merge 1 commit into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an infinite polling hang in
fern generatewhere the CLI never detects task completion despite the Fiddle coordinator correctly returning"_type": "finished"status.Root Cause
The fiddle-sdk's
TaskStatus._visit()method calls visitor functions but does notawaitasync handler results. WhenprocessUpdate()calledawait remoteTask.status._visit({...}), theawaitresolved immediately (the_visitreturn value is not the handler's Promise), so#isFinishedwas never set before the polling loop checked it — causing infinite polling.Changes Made
_visit()with directswitchonstatus.typeinRemoteTaskHandler.processUpdate()— this allows properawaitof the asyncdownloadFilesForTaskcall before setting#isFinished = truetimeout: 60_000(connection) +AbortSignal.timeout(5 min)(overall) on bothdownloadZipForTaskanddownloadAndExtractZipToDirectoryto prevent indefinite hangs on slow/stalled downloadsnoopimport, addassertNeverNoThrowfor forward-compatible handling of unknown status types in the default caseTesting
pnpm turbo run compile --filter @fern-api/remote-workspace-runner)pnpm turbo run test --filter @fern-api/remote-workspace-runner)Link to Devin session: https://app.devin.ai/sessions/ac52847fd52a4366b0f8e9125af51345
Requested by: @Swimburger