Skip to content

fix(cli): add S3 download timeouts to prevent remote generation hang #16764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Swimburger wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(cli): add S3 download timeouts to prevent remote generation hang #16764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1aa83b7
fix(cli): fix remote generation polling hang after task completion
Swimburger Jun 26, 2026
857fff8
fix(cli): add S3 download timeouts to prevent remote generation hang
Swimburger Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/cli/cli/changes/unreleased/fix-remote-gen-polling-hang.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
- summary: |
Fix remote generation CLI hanging indefinitely when S3 download stalls.
Added connection timeout (60s) and overall download timeout (5 min) to
both downloadZipForTask and downloadAndExtractZipToDirectory, so the CLI
fails with a clear error instead of blocking forever.
type: fix
11 changes: 9 additions & 2 deletions packages/cli/generation/remote-generation/remote-workspace-runner/src/RemoteTaskHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,6 +480,9 @@ async function downloadFilesForTask({
}
}

/** Maximum time (ms) to wait for the S3 download to complete, including streaming. */
const S3_DOWNLOAD_TIMEOUT_MS = 5 * 60 * 1_000;

async function downloadZipForTask({
s3PreSignedReadUrl,
absolutePathToLocalOutput
Expand All @@ -489,7 +492,9 @@ async function downloadZipForTask({
}): Promise<void> {
// initiate request
const request = await axios.get(s3PreSignedReadUrl, {
responseType: "stream"
responseType: "stream",
timeout: 60_000,
signal: AbortSignal.timeout(S3_DOWNLOAD_TIMEOUT_MS)
});

// pipe to zip
Expand Down Expand Up @@ -655,7 +660,9 @@ async function downloadAndExtractZipToDirectory({
outputPath: AbsoluteFilePath;
}): Promise<void> {
const request = await axios.get(s3PreSignedReadUrl, {
responseType: "stream"
responseType: "stream",
timeout: 60_000,
signal: AbortSignal.timeout(S3_DOWNLOAD_TIMEOUT_MS)
});

const tmpDir = await tmp.dir({ prefix: "fern", unsafeCleanup: true });
Expand Down