[cache] Drop mq policy tests while making them optional via config

[fsuba]

Drop tests for the legacy mq policy, while introduce a new config option cache_policy to test it optionally.

Summary by CodeRabbit

• Chores
  • Updated the example configuration file to document a new optional cache policy parameter for tests.
  • Simplified and consolidated cache test cases by removing duplicated policy-specific variants and streamlining test registration.
  • Reduced and clarified test entries in the test dependencies configuration to eliminate redundant variants.

[coderabbitai]

Walkthrough

The changes consolidate cache policy handling in dm-cache tests by introducing an optional cache_policy configuration parameter. Test functions are refactored to read the policy from configuration instead of explicit arguments, and redundant policy-specific test variants are removed. Test registration and dependency files are updated to reflect this unification.

Changes

File(s)	Change Summary
config.toml.example	Added an optional, commented-out cache_policy parameter with documentation for overriding the default cache policy.
src/dmtest/cache/resize_origin_tests.py	Refactored test functions to read cache policy from config, renamed functions, and removed policy-specific wrappers.
src/dmtest/cache/small_config_tests.py	Renamed and simplified test function to read policy from config, removed policy-specific test variants.
test_dependencies.toml	Removed _mq and _smq test entries, consolidating to single test entries per test.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant TestRunner
    participant Config
    participant TestFunction

    User->>TestRunner: Start test
    TestRunner->>Config: Load config.toml
    Config-->>TestRunner: Provide config (may include cache_policy)
    TestRunner->>TestFunction: Call with fixture (fix)
    TestFunction->>Config: Read cache_policy (default "smq" if missing)
    TestFunction-->>TestRunner: Execute test using selected policy

Loading

Poem

In the warren of tests, a policy hop,
Now one config guides where once two would stop.
No more suffixes, just a single, clear path,
The cache bunnies cheer with a jubilant laugh!
With less duplication and more harmony,
Our code garden grows—oh, what a sight to see!
🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

---

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3f376d8 and 244faab.

📒 Files selected for processing (4)

• config.toml.example (1 hunks)
• src/dmtest/cache/resize_origin_tests.py (6 hunks)
• src/dmtest/cache/small_config_tests.py (2 hunks)
• test_dependencies.toml (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

src/dmtest/cache/resize_origin_tests.py (1)

src/dmtest/fixture.py (1)

• cfg (13-14)

🔇 Additional comments (11)

config.toml.example (1)

11-14: Well-documented configuration option added

The new cache_policy configuration option is clearly documented with helpful comments explaining its purpose and default behavior. This provides good user guidance on how to override the default cache policy in tests.

test_dependencies.toml (1)

317-339: Simplified test dependency structure

The test entries with _mq and _smq suffixes have been successfully removed, leaving only the base test names. This aligns well with the approach of using a configurable policy rather than having separate tests for each policy, reducing maintenance overhead and test duplication.

src/dmtest/cache/small_config_tests.py (3)

8-14: Good refactoring of test function signature

The function has been renamed with a t_ prefix and simplified by removing the explicit policy parameter. The code now properly retrieves the policy name from the configuration with a sensible default of "smq".

---

24-24: Policy configuration correctly applied

The CachePolicy is now created using the policy name from configuration, allowing for flexible policy testing without code changes.

---

35-35: Test registration properly updated

The test registration has been correctly updated to use the single consolidated test function with the new name.

src/dmtest/cache/resize_origin_tests.py (6)

79-84: Consistent function refactoring pattern

The function has been renamed with a t_ prefix and now retrieves the policy name from configuration, maintaining consistency with the other refactored functions.

---

122-127: Policy retrieval consistently implemented

Good implementation of policy name retrieval from configuration with the same default value as other functions.

---

168-173: Maintains pattern consistency

The refactoring pattern is consistently applied across all test functions, ensuring uniform behavior.

---

212-217: Consistent implementation of configuration-based policy

The same pattern of retrieving policy from configuration is correctly applied here as well.

---

257-262: Completes the refactoring pattern

The final test function follows the same refactoring pattern, completing the transition to configuration-based policy testing.

---

308-317: Test registration correctly updated

All test registrations have been properly updated to use the new function names with the t_ prefix, ensuring the tests will run correctly with the new implementation.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[fsuba]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.