Fix mask isub + tracksdata update - #264
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- Add regression test: erasing an interior pixel (bbox unchanged) must clear it in the segmentation GraphArrayView. Fails with the old in-place __isub__. - Fix test_from_tracks_cls: assert segmentation identity instead of ==, which is element-wise (ambiguous) on newer tracksdata GraphArrayView. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #264 +/- ##
=======================================
Coverage 93.78% 93.78%
=======================================
Files 59 59
Lines 3284 3285 +1
=======================================
+ Hits 3080 3081 +1
Misses 204 204 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
TeunHuijben
changed the title
TeunHuijben
marked this pull request as ready for review
July 27, 2026 19:57
Contributor
|
Oh yes I found this isub bug too 😆 can we potentially implement mask normal sub in funtracks as well? |
cmalinmayor
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does tracksdata maintenance, namely:
tracksdatato the latestv0.1.0rc7UpdateNodeSegwhereMask.__isub__works in-place, and funtracks mistakenly assumed it didn't. I fixed the.__isub__line and added a test that captures this. (this solves failing motile_tracker tests in segmentation_shape consistency motile_tracker#463)