Skip to content

ref(groupingInfo): Delete EventGroupingInfoResponseOld #101223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 7, 2025
Merged

ref(groupingInfo): Delete EventGroupingInfoResponseOld #101223

merged 12 commits into from
Nov 7, 2025

Conversation

@shayna-ch
Copy link
Member

@shayna-ch shayna-ch commented Oct 8, 2025 •
edited
Loading

Follow up to #101135
Delete EventGroupingInfoResponseOld

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 8, 2025
@shayna-ch shayna-ch requested a review from lobsterkatie October 8, 2025 22:35
lobsterkatie
lobsterkatie approved these changes Oct 9, 2025
View reviewed changes
Copy link
Member

@lobsterkatie lobsterkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lobsterkatie lobsterkatie mentioned this pull request Oct 9, 2025
Merged
@shayna-ch shayna-ch marked this pull request as ready for review November 4, 2025 18:20
@shayna-ch shayna-ch marked this pull request as draft November 4, 2025 18:22
Base automatically changed from shayna-ch/groupinginfo-fe-restructure-1 to master November 5, 2025 21:42
lobsterkatie added a commit that referenced this pull request Nov 6, 2025
@lobsterkatie
ref(grouping): Move grouping config to top level of grouping info (#1…
e26681e 
…01281)

This changes the format of the grouping info API response, so that instead of the full serialized grouping config being included in every variant, only the grouping config id is included at the top level of the JSON, and the variants in turn are included under a new `variants` key. In other words, it changes from a response that looks like this:

{
  app_exception_stacktrace: {
    ...,
    config: {
      id: "newstyle:whatever",  // the only part of `config` we actually care about
      ...
    }
  },
  system_exception_stacktrace:  {
    ...,
    config: {
      id: "newstyle:whatever",  // we don't need this twice
      ...
    }
  }
}

to one which looks like this:

{
  grouping_config: "newstyle:whatever",
  variants: {
    app_exception_stacktrace: {...},
    system_exception_stacktrace: {...}
  }
}

This not only removes redundancy (along with a bunch of information about the config we don't need), it also sets us up to be able to send other grouping-info-wide information in the response.

Note: Before this can be merged, the front end needs to be adjusted to [work with both the old and new formats](#102820). Once that's deployed, and this is merged and deployed, we can [remove old-format handling from the front end](#101223).
Ahmed-Labs pushed a commit that referenced this pull request Nov 6, 2025
@lobsterkatie @Ahmed-Labs
ref(grouping): Move grouping config to top level of grouping info (#1…
e97ecb8 
…01281)

This changes the format of the grouping info API response, so that instead of the full serialized grouping config being included in every variant, only the grouping config id is included at the top level of the JSON, and the variants in turn are included under a new `variants` key. In other words, it changes from a response that looks like this:

{
  app_exception_stacktrace: {
    ...,
    config: {
      id: "newstyle:whatever",  // the only part of `config` we actually care about
      ...
    }
  },
  system_exception_stacktrace:  {
    ...,
    config: {
      id: "newstyle:whatever",  // we don't need this twice
      ...
    }
  }
}

to one which looks like this:

{
  grouping_config: "newstyle:whatever",
  variants: {
    app_exception_stacktrace: {...},
    system_exception_stacktrace: {...}
  }
}

This not only removes redundancy (along with a bunch of information about the config we don't need), it also sets us up to be able to send other grouping-info-wide information in the response.

Note: Before this can be merged, the front end needs to be adjusted to [work with both the old and new formats](#102820). Once that's deployed, and this is merged and deployed, we can [remove old-format handling from the front end](#101223).
@shayna-ch shayna-ch marked this pull request as ready for review November 7, 2025 18:25
@shayna-ch shayna-ch marked this pull request as draft November 7, 2025 18:35
@shayna-ch shayna-ch marked this pull request as ready for review November 7, 2025 18:38
@shayna-ch shayna-ch merged commit 35f2723 into master Nov 7, 2025
47 checks passed
@shayna-ch shayna-ch deleted the shayna-ch/groupinginfo-fe-restructure-2 branch November 7, 2025 19:16
Jesse-Box pushed a commit that referenced this pull request Nov 12, 2025
@lobsterkatie @Jesse-Box
ref(grouping): Move grouping config to top level of grouping info (#1…
f151a6f 
…01281)

This changes the format of the grouping info API response, so that instead of the full serialized grouping config being included in every variant, only the grouping config id is included at the top level of the JSON, and the variants in turn are included under a new `variants` key. In other words, it changes from a response that looks like this:

{
  app_exception_stacktrace: {
    ...,
    config: {
      id: "newstyle:whatever",  // the only part of `config` we actually care about
      ...
    }
  },
  system_exception_stacktrace:  {
    ...,
    config: {
      id: "newstyle:whatever",  // we don't need this twice
      ...
    }
  }
}

to one which looks like this:

{
  grouping_config: "newstyle:whatever",
  variants: {
    app_exception_stacktrace: {...},
    system_exception_stacktrace: {...}
  }
}

This not only removes redundancy (along with a bunch of information about the config we don't need), it also sets us up to be able to send other grouping-info-wide information in the response.

Note: Before this can be merged, the front end needs to be adjusted to [work with both the old and new formats](#102820). Once that's deployed, and this is merged and deployed, we can [remove old-format handling from the front end](#101223).
Jesse-Box pushed a commit that referenced this pull request Nov 12, 2025
@shayna-ch @Jesse-Box
ref(groupingInfo): Delete EventGroupingInfoResponseOld (#101223)
2279879
andrewshie-sentry pushed a commit that referenced this pull request Nov 13, 2025
@lobsterkatie @andrewshie-sentry
ref(grouping): Move grouping config to top level of grouping info (#1…
b43e840 
…01281)

This changes the format of the grouping info API response, so that instead of the full serialized grouping config being included in every variant, only the grouping config id is included at the top level of the JSON, and the variants in turn are included under a new `variants` key. In other words, it changes from a response that looks like this:

{
  app_exception_stacktrace: {
    ...,
    config: {
      id: "newstyle:whatever",  // the only part of `config` we actually care about
      ...
    }
  },
  system_exception_stacktrace:  {
    ...,
    config: {
      id: "newstyle:whatever",  // we don't need this twice
      ...
    }
  }
}

to one which looks like this:

{
  grouping_config: "newstyle:whatever",
  variants: {
    app_exception_stacktrace: {...},
    system_exception_stacktrace: {...}
  }
}

This not only removes redundancy (along with a bunch of information about the config we don't need), it also sets us up to be able to send other grouping-info-wide information in the response.

Note: Before this can be merged, the front end needs to be adjusted to [work with both the old and new formats](#102820). Once that's deployed, and this is merged and deployed, we can [remove old-format handling from the front end](#101223).
andrewshie-sentry pushed a commit that referenced this pull request Nov 13, 2025
@shayna-ch @andrewshie-sentry
ref(groupingInfo): Delete EventGroupingInfoResponseOld (#101223)
b1b0fe6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lobsterkatie lobsterkatie lobsterkatie approved these changes

Assignees

No one assigned

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shayna-ch @lobsterkatie