Skip to content

fix(project): handle registry list retrieval error gracefully #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saiashok0981 wants to merge 1 commit into from
+9 −7
Closed

fix(project): handle registry list retrieval error gracefully #1014

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions pkg/views/project/create/view.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,15 +53,17 @@ func getRegistryList() (*registry.ListRegistriesOK, error) {

func CreateProjectView(createView *CreateView) error {
theme := huh.ThemeCharm()
// I want it to be a map of registry ID to registry name
// Registry list is optional: if retrieval fails, the proxy-cache registry
// selector will simply be hidden and the form can still proceed.
registryOptions := map[string]string{}
registries, err := getRegistryList()
if err != nil {
return err
}
registryOptions := map[string]string{}
for _, registry := range registries.Payload {
regiId := fmt.Sprintf("%d", registry.ID)
registryOptions[regiId] = fmt.Sprintf("%s (%s)", registry.Name, registry.URL)
log.Warnf("failed to retrieve registry list, proxy cache registry selection will be unavailable: %v", err)
} else {
for _, r := range registries.Payload {
regiId := fmt.Sprintf("%d", r.ID)
registryOptions[regiId] = fmt.Sprintf("%s (%s)", r.Name, r.URL)
}
}

var registrySelectOptions []huh.Option[string]
Expand Down