ci(kokoro): fix core_deps_from_source for google-auth - #17526
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the .kokoro/system.sh script to conditionally set NOX_FILE and NOX_SESSION based on the value of NOX_SESSION. The review feedback correctly identifies a redundant self-assignment of NOX_SESSION in the else block and provides a clean suggestion to remove it.
Comment on lines
+66
to
+69
| else | ||
| NOX_FILE="noxfile.py" | ||
| NOX_SESSION="${NOX_SESSION}" | ||
| fi |
Contributor
There was a problem hiding this comment.
The assignment NOX_SESSION="${NOX_SESSION}" is redundant because it assigns the variable to itself. This can be safely removed.
Suggested change
| else | |
| NOX_FILE="noxfile.py" | |
| NOX_SESSION="${NOX_SESSION}" | |
| fi | |
| else | |
| NOX_FILE="noxfile.py" | |
| fi |
ohmayr
force-pushed
the
fix-core-deps-auth
branch
from
June 22, 2026 17:57
f487a30 to
5eab08e
Compare
ohmayr
marked this pull request as ready for review
June 22, 2026 18:00
ohmayr
changed the title
core_deps_from_source for google-auth
parthea
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #17527
See logs: https://fusion2.corp.google.com/ci;prev=s/kokoro/prod:cloud-devrel%2Fclient-libraries%2Fpython%2Fgoogleapis%2Fgoogle-cloud-python%2Fpresubmit%2Fsystem/activity/53fd6866-f69c-4bad-922e-f806b3833299/log?q=google-cloud-python&s=p