Skip to content

ci(kokoro): fix core_deps_from_source for google-auth #17526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ohmayr merged 3 commits into from
Jun 22, 2026
Merged

ci(kokoro): fix core_deps_from_source for google-auth #17526

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5eab08e
ci(kokoro): fix NOX_FILE and NOX_SESSION override for google-auth in …
ohmayr Jun 22, 2026
be14270
address feedback
ohmayr Jun 22, 2026
277eb58
address PR feedback
ohmayr Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .kokoro/system.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,15 @@ run_package_test() {

PROJECT_ID=$(cat "${KOKORO_GFILE_DIR}/google-auth-project-id.json")
GOOGLE_APPLICATION_CREDENTIALS="${KOKORO_GFILE_DIR}/google-auth-service-account.json"
NOX_FILE="system_tests/noxfile.py"
NOX_SESSION=""
# Note: system.sh is also reused for monorepo-wide continuous unit test jobs
# like `core_deps_from_source` and `prerelease_deps`. For google-auth, we only
# want to override NOX_FILE to system_tests/noxfile.py when running actual system tests.
if [[ -z "${NOX_SESSION}" || "${NOX_SESSION}" == "system-"* ]]; then
NOX_FILE="system_tests/noxfile.py"
NOX_SESSION=""
else
NOX_FILE="noxfile.py"
fi
Comment on lines +69 to +71

@gemini-code-assist gemini-code-assist Bot Jun 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The assignment NOX_SESSION="${NOX_SESSION}" is redundant because it assigns the variable to itself. This can be safely removed.

Suggested change
else
NOX_FILE="noxfile.py"
NOX_SESSION="${NOX_SESSION}"
fi
else
NOX_FILE="noxfile.py"
fi

;;
*)
PROJECT_ID=$(cat "${KOKORO_GFILE_DIR}/project-id.json")
Expand Down
Loading