feat(pubsub): implement into_stream for a Session#4590
feat(pubsub): implement into_stream for a Session#4590haphungw wants to merge 7 commits intogoogleapis:mainfrom
into_stream for a Session#4590Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4590 +/- ##
=======================================
Coverage 95.01% 95.01%
=======================================
Files 195 195
Lines 7458 7464 +6
=======================================
+ Hits 7086 7092 +6
Misses 372 372 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b793089 to
5af3de9
Compare
into_stream for a Session
dbolduc
left a comment
There was a problem hiding this comment.
The code all looks good.
- we definitely need to exercise the new feature in our CI
- we should document the new feature
- the tests could be cleaned up a bit
5af3de9 to
c46d369
Compare
c46d369 to
c1e4461
Compare
dbolduc
left a comment
There was a problem hiding this comment.
Just the docs thing, then I think we are good to go
| //! [gcloud-pubsub]: https://crates.io/crates/gcloud-pubsub | ||
| //! [ring]: https://crates.io/crates/ring | ||
|
|
||
| #[cfg_attr(docsrs, feature(doc_cfg))] |
There was a problem hiding this comment.
This works?? I think it should be:
| #[cfg_attr(docsrs, feature(doc_cfg))] | |
| #![cfg_attr(docsrs, feature(doc_cfg))] | |
basically #[...] applies to the thing immediately below it, but #![...] applies to the module in scope, which in lib.rs, is the whole crate.
There was a problem hiding this comment.
Ahh lol, we only try to build 20 crates on PRs (probably for timing reasons). I guess pubsub is not one of them.
google-cloud-rust/.gcb/scripts/docs-rs.sh
Lines 25 to 28 in 6e053dd
I think the post-merge build would fail.
Allow
Sessionto be used as afutures::Stream. This enables the use of streaming primitives for message processing.This feature is gated behind
unstable-streamto maintain API stability.Fixes #4574