fix: false-positive Stackdriver error in diagnose #31616
+38
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the bug in
operator diagnoseas described in #31615.operator diagnosecontains checks to validate your Telemetry configuration. However, due to a glitch in how thecoalescehelper handles booleans, it always reports an error with missing Stackdriver configuration if you omit Stackdriver settings (even if you specify other telemetry backend values correctly).This change simply pulls the boolean out of the coalesce call and checks it separately. An updated unit test is included to validate a dogstatsd-only configuration.
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch.PCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.