Skip to content

Conversation

@rnubel
Copy link

@rnubel rnubel commented Oct 30, 2025

Description

Fixes the bug in operator diagnose as described in #31615.

operator diagnose contains checks to validate your Telemetry configuration. However, due to a glitch in how the coalesce helper handles booleans, it always reports an error with missing Stackdriver configuration if you omit Stackdriver settings (even if you specify other telemetry backend values correctly).

This change simply pulls the boolean out of the coalesce call and checks it separately. An updated unit test is included to validate a dogstatsd-only configuration.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • Jira: If this change has an associated Jira, it's referenced either in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.

Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@rnubel rnubel requested a review from a team as a code owner October 30, 2025 16:51
@rnubel rnubel requested a review from drivera258 October 30, 2025 16:51
@hashicorp-cla-app
Copy link

hashicorp-cla-app bot commented Oct 30, 2025

CLA assistant check
All committers have signed the CLA.

@hashicorp-cla-app
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@vercel
Copy link

vercel bot commented Oct 30, 2025

@rnubel is attempting to deploy a commit to the HashiCorp Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

operator diagnose reports incorrect error for telemetry configuration

2 participants