Skip to content

Follow hlint suggestion: use lambda-case#11807

Merged
mergify[bot] merged 1 commit into
haskell:masterfrom
cabalism:hlint/use-lambda-case
May 16, 2026
Merged

Follow hlint suggestion: use lambda-case#11807
mergify[bot] merged 1 commit into
haskell:masterfrom
cabalism:hlint/use-lambda-case

Conversation

@philderbeast
Copy link
Copy Markdown
Collaborator

See #9110. Discharges and no longer ignores HLint's "use lambda-case" suggestion so that these will be suggested by our CI linting.

I'll squash commits before applying the merge label if this pull request is approved. I've left the styling change to module CmdHaddockProject separate for an easier review.


  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

Copy link
Copy Markdown
Collaborator

@jappeace jappeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Comment thread cabal-install/src/Distribution/Client/CmdHaddockProject.hs
Comment thread cabal-install/src/Distribution/Client/CmdHaddockProject.hs
@ulysses4ever
Copy link
Copy Markdown
Collaborator

I'm borderline on lambda case: I like to use it myself a lot but I'd rather we don't force it on contributors: arguably, this raises the bar a bit, and I've seen Haskell newcomers who were deeply confused by this syntax.

But since the necessary two approvals are in and my doubts aren't backed by any real data, I won't block it.

@philderbeast philderbeast force-pushed the hlint/use-lambda-case branch from c102aa1 to d5335c2 Compare May 14, 2026 15:32
@philderbeast philderbeast added merge me Tell Mergify Bot to merge and removed attention: needs-review labels May 14, 2026
@mergify mergify Bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days queued labels May 14, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 16, 2026

Merge Queue Status

This pull request spent 1 hour 41 minutes 10 seconds in the queue, including 1 hour 30 minutes 34 seconds running CI.

Required conditions to merge
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Validate post job
    • check-neutral = Validate post job
    • check-skipped = Validate post job
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

mergify Bot added a commit that referenced this pull request May 16, 2026
mergify Bot added a commit that referenced this pull request May 16, 2026
@mergify mergify Bot merged commit 423442c into haskell:master May 16, 2026
211 of 212 checks passed
@mergify mergify Bot removed the queued label May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants