Batch streamed message.updates through the rAF flush#2413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
During streaming,
.contentupdates are batched to animation frames, butmessage.updateswas reassigned synchronously on every network chunk. At 100+ chunks/s (fast providers), each assignment re-triggers the full markdown block derivation, so the app does per-chunk work its own rAF batching was designed to avoid.This PR routes
.updatesthrough the same flush as.content: the stream loop maintains a localupdatesBuffer(all in-loop readers use it, including the token-merge logic and the final-answer tool check), and the reactive field is assigned only at flush points. Non-stream updates (tool status, final answer, errors) flush immediately, exactly as before, so tool visibility timing is unchanged.The navigation-abort exit path now flushes the buffers before returning. That path skips the post-stream refresh by design, so anything left in the buffers would otherwise be dropped from the UI for good.
Verification
message.updates: none remain (single flush point)Part of a performance series measured from a live profile of hf.co/chat. Each PR is file-disjoint and merges independently, in any order: #2409 (compression), #2410 (models payload), #2411 (markdown pipeline), #2412 (conversation switching), #2413 (stream update batching), #2414 (send handler DB), #2415 (sidebar hydration).