Key the sidebar conversation list and lazy-mount the mobile drawer#2415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two sidebar fixes:
NavMenu's conversation list{#each}was unkeyed while new conversations are prepended withunshift. Positional reconciliation can attach row-local state (open dropdown menu, inline rename, delete confirmation) to the wrong conversation when the list shifts. Keyed byString(conv.id)(ids can beObjectId | string, and object identity is not stable across list rebuilds).NavMenuthat was always mounted (hidden via CSS transform), so every page load SSRs and hydrates the conversation list twice. The drawer content now mounts on first open (or swipe) and stays mounted afterward, preserving the slide animation and inner scroll position.Verification
Part of a performance series measured from a live profile of hf.co/chat. Each PR is file-disjoint and merges independently, in any order: #2409 (compression), #2410 (models payload), #2411 (markdown pipeline), #2412 (conversation switching), #2413 (stream update batching), #2414 (send handler DB), #2415 (sidebar hydration).