-
Notifications
You must be signed in to change notification settings - Fork 988
Optimise engine_getPayload* and engine_getBlobsV2 #9445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
siladu
merged 7 commits into
hyperledger:main
from
siladu:optimise-getPayload-rpcs-toFastHex
Nov 24, 2025
Merged
Optimise engine_getPayload* and engine_getBlobsV2 #9445
siladu
merged 7 commits into
hyperledger:main
from
siladu:optimise-getPayload-rpcs-toFastHex
Nov 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c661321 to
1204c0b
Compare
In prep for using optimised HexUtil.toFastHex Add missing EngineGetPayloadV5 unit Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
1204c0b to
ade8488
Compare
engine_getBlobsV2+ and engine_getPayloadV5+ Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
…-rpcs-toFastHex Signed-off-by: Simon Dudley <[email protected]>
This was referenced Nov 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Gabriel-Trintinalia
previously approved these changes
Nov 24, 2025
Contributor
Gabriel-Trintinalia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Simon Dudley <[email protected]>
Gabriel-Trintinalia
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on #9426.
Use
HexUtils.toFastHexforengine_getPayloadrelated requests includingengine_getPayloadBodies*Main change is
84e3fdf(#9445)Also use parallelStreams
8c4f518(#9445)The most impactful optimisation is for BlobsBundleV2 used in engine_getPayloadV5+ as it is impacted by blob scaling the same way as #9426
Tested engine_getPayloadV5 impact on a hoodi validator:

Parallel stream improvement for engine_getBlobsV2 versus #9426:
