Add API key authentication to ApiServer#13
Open
thechibuikem wants to merge 2 commits into
Open
Conversation
This was referenced Jul 5, 2026
Member
|
Interesting insight, I provided my answer through zulip |
subhramit
reviewed
Jul 10, 2026
Member
There was a problem hiding this comment.
Please revert the formatting changes to this file
subhramit
reviewed
Jul 10, 2026
| when(req.getHeader("X-API-Key")).thenReturn("secret"); | ||
| assertNull(ApiServer.checkAuth(req, "secret")); | ||
| } | ||
| } No newline at end of file |
Member
There was a problem hiding this comment.
Add a newline here. This can also be covered by Checkstyle eventually.
subhramit
reviewed
Jul 10, 2026
Comment on lines
+5
to
+6
| import static org.junit.Assert.*; | ||
| import static org.mockito.Mockito.*; |
Member
There was a problem hiding this comment.
Don't import *, just import the required methods
subhramit
requested changes
Jul 10, 2026
subhramit
left a comment
subhramit
left a comment
Member
There was a problem hiding this comment.
Hey, can you provide some steps to manually test this?
Also can you look into if assertEquals needs explicit boxing for comparison? (Integer.valueOf)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses hyphae/APIS#91 (item 1: Unauthenticated Control APIs)
Adds timing-safe X-API-Key header check to ApiServer's HTTP request handler, covering all three handlers (ErrorGeneration, DealGeneration, LogConfiguration) since the check runs before dispatch. Returns 500 if apiKey unconfigured, 401 on missing/invalid key.
Tests
ApiServerAuthTest: missing key, empty key, missing header, wrongheader, valid header.
Follow-up (separate PRs)