Repository navigation
feat: show what really broke behind failed tests in the PR comment - #4
Merged
Merged
Conversation
The central run now groups failed tests by their real cause (an app crash, a browser error, a server error, or the check that failed), with an example test, its screenshot and trace, and the code at a crash. The comment shows them as a table under the headline, quotes the code, keeps known failures apart as "probably not from your PR", and, when a crash or browser error leads and the PR changes a dependency's version in package.json, points at that bump. Table cells cannot be broken by pipes in error text. A crash among failed tests is titled "failed", not "couldn't run your build". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Even with #3's headline, a developer with 61 failed tests still had to open the report, then a trace, then its Console tab, to find out that 37 of them were one crash, caused by the SDK bump in their own PR (os#617).
Change
When the central result carries
causes(iblai/iblai-deploy-ops#79 groups failed tests by what really broke), the comment shows them under the headline:package.jsondiff with one compare API call using the caller's token;deps_from_patchkeeps only changed versions.pattern: tests_failed_crash) is titled "❌ PR E2E failed", not "couldn't run your build".Testing
tests/test-render.py, 11 new cases:render.py, all caught.action.yml(as YAML hands it to bash), run on Michael's SDK-bump commitf9bb8e0b: it yields@iblai/iblai-js 2.50.1 → 2.58.1.gh api markdown, gives a table of 2 rows × 3 cells, the code block, and no stray pipes.🤖 Generated with Claude Code