normalize issuer as a sanity check #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inexperienced devs/users may not know whether to include a final slash (/) at the end of their issuer field in their metadata endpoint. Also, it seems some OIDC/OAuth modules may require there to NOT be a final slash (/) at the end of the issuer. This change is intended to make it less error prone overall.
Contributor
Author
|
This is to reopen #27 because I accidentially closed it, not fully understanding how forks worked. |
Contributor
Author
|
This issue is also documented within my usage of this library. |
Contributor
Author
|
Further detail: I did not explore where this occurs, but somewhere in my implementation one library expects there to be an ending slash and another library expects there to be no ending slash. This has been what has been making them behave together. |
Member
|
Attempting to close and re-open this PR so the workflow runs 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inexperienced devs/users may not know whether to include a final slash (/) at the end of their issuer field in their metadata endpoint. Also, it seems some OIDC/OAuth modules may require there to NOT be a final slash (/) at the end of the issuer.
This change is intended to make it less error prone overall.