Skip to content

🌱 enhance mhc events #12930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −2
Open

🌱 enhance mhc events #12930

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e6992d
Add event for remediation in MachineHealthCheck
nayuta723 Oct 26, 2025
1bd0780
Improve MachineHealthCheck event messages
nayuta723 Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions internal/controllers/machinehealthcheck/machinehealthcheck_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,6 +539,14 @@ func (r *Reconciler) patchUnhealthyTargets(ctx context.Context, logger logr.Logg
klog.KObj(t.Machine),
klog.KObj(t.MHC),
)
// Record event on MachineHealthCheck to track remediation history
r.recorder.Eventf(
m,
corev1.EventTypeNormal,
EventRemediationTriggered,
"Triggered remediation for unhealthy Machine %s",
Copy link
Member

@fabriziopandini fabriziopandini Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remediation is not triggered by MHC, MHC only marks the machine as unhealthy (as well as it unmarks it in case it goes back to healthy).

Also, I would not add the name of the machine to an event added to the machine itself, it is redundant. May be, let's consider instead to track which MHC instance applied the event

Copy link
Contributor Author

@nayuta723 nayuta723 Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as well as it unmarks it in case it goes back to healthy

Should I handle this as well?

klog.KObj(t.Machine),
)
}
return errList
}
Expand Down
2 changes: 2 additions & 0 deletions internal/controllers/machinehealthcheck/machinehealthcheck_targets.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ const (

// EventMachineMarkedUnhealthy is emitted when machine was successfully marked as unhealthy.
EventMachineMarkedUnhealthy string = "MachineMarkedUnhealthy"
// EventRemediationTriggered is emitted when MachineHealthCheck triggers remediation for an unhealthy machine.
EventRemediationTriggered string = "RemediationTriggered"
)

var (
Expand Down