Skip to content

Remove the eigen submodule - #664

Merged
Yurlungur merged 2 commits into
mainfrom
jmm/eigen-package
Oct 27, 2026
Merged

Yurlungur merged 2 commits into
mainfrom
jmm/eigen-package

Conversation

@Yurlungur

@Yurlungur Yurlungur commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

PR Summary

This solves the same problem as #663 , where gitlab's rate limiting is causing CI failures. In that MR, I removed eigen completely.

This is a much more minimal change. I remove the submodule, and add an optional fetch content functionality. But the default is is to use find package, if Eigen is requested.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI
  • If ML was used, make sure to add a disclaimer at the top of a file indicating ML was used to assist in generating the file.
  • If Agentic AI was used, have the AI generate a "proposed changes" markdown file and store it in the plan_histories folder, with a filename the same as the MR number.

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Maintainers: ensure spackages are up to date:
    • LANL-internal team, update XCAP spackages
    • Current maintainer of upstream spackages, submit MR to spack

@Yurlungur Yurlungur self-assigned this Oct 27, 2026
@Yurlungur Yurlungur added the build Something to do with the build system label Oct 27, 2026
@Yurlungur

Copy link
Copy Markdown
Collaborator Author

Tests now passing on re-git

@Yurlungur Yurlungur linked an issue Oct 27, 2026 that may be closed by this pull request
@Yurlungur Yurlungur mentioned this pull request Oct 27, 2026
7 of 13 tasks
@Yurlungur
Yurlungur merged commit e1b2639 into main Oct 27, 2026
10 checks passed
@Yurlungur
Yurlungur deleted the jmm/eigen-package branch October 27, 2026 18:54
macro(singularity_import_eigen)
macro(singularity_find_eigen)
if(NOT TARGET Eigen3::Eigen)
find_package(Eigen3 QUIET)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FetchContent_MakeAvailable will call find_package if requested in FetchContent_Declare (see docs here). I can't recall if we separated out the logic here for another reason, but this could be simplified if needed.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok that's probably worth simplifying at some point

set(KokkosKernels_INST_OFFSET_SIZE_T OFF CACHE BOOL "" FORCE)
set(KokkosKernels_INST_ORDINAL_INT OFF CACHE BOOL "" FORCE)
set(KokkosKernels_INST_ORDINAL_INT OFF CACHE BOOL "" FORCE)
elseif(${pkg} STREQUAL "Eigen3")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC Fetch_Content will somewhere do add_subdirectory. Should these be removed? It won't effect the build of SEOS but it could lead to longer build times.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand---The lines you commented on are removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Something to do with the build system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove eigen?

5 participants