Repository navigation
Remove the eigen submodule - #664
Merged
Merged
Conversation
Yurlungur
requested review from
adamdempsey90,
buechlerm,
jdolence,
pdmullen and
rbberger
October 27, 2026 18:12
Collaborator
Author
|
Tests now passing on re-git |
Closed
rbberger
approved these changes
Oct 27, 2026
adamdempsey90
approved these changes
Oct 27, 2026
cmauney
reviewed
Oct 27, 2026
| macro(singularity_import_eigen) | ||
| macro(singularity_find_eigen) | ||
| if(NOT TARGET Eigen3::Eigen) | ||
| find_package(Eigen3 QUIET) |
Contributor
There was a problem hiding this comment.
FetchContent_MakeAvailable will call find_package if requested in FetchContent_Declare (see docs here). I can't recall if we separated out the logic here for another reason, but this could be simplified if needed.
Collaborator
Author
There was a problem hiding this comment.
ok that's probably worth simplifying at some point
cmauney
reviewed
Oct 27, 2026
| set(KokkosKernels_INST_OFFSET_SIZE_T OFF CACHE BOOL "" FORCE) | ||
| set(KokkosKernels_INST_ORDINAL_INT OFF CACHE BOOL "" FORCE) | ||
| set(KokkosKernels_INST_ORDINAL_INT OFF CACHE BOOL "" FORCE) | ||
| elseif(${pkg} STREQUAL "Eigen3") |
Contributor
There was a problem hiding this comment.
IIRC Fetch_Content will somewhere do add_subdirectory. Should these be removed? It won't effect the build of SEOS but it could lead to longer build times.
Collaborator
Author
There was a problem hiding this comment.
Not sure I understand---The lines you commented on are removed.
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This solves the same problem as #663 , where gitlab's rate limiting is causing CI failures. In that MR, I removed eigen completely.
This is a much more minimal change. I remove the submodule, and add an optional fetch content functionality. But the default is is to use find package, if Eigen is requested.
PR Checklist
make formatcommand after configuring withcmake.plan_historiesfolder, with a filename the same as the MR number.If preparing for a new release, in addition please check the following: