Repository navigation
Remove the eigen submodule #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -48,14 +48,6 @@ macro(singularity_cmake_config pkg) | |
| set(KokkosKernels_INST_OFFSET_SIZE_T OFF CACHE BOOL "" FORCE) | ||
| set(KokkosKernels_INST_ORDINAL_INT OFF CACHE BOOL "" FORCE) | ||
| set(KokkosKernels_INST_ORDINAL_INT OFF CACHE BOOL "" FORCE) | ||
| elseif(${pkg} STREQUAL "Eigen3") | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. IIRC
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure I understand---The lines you commented on are removed. |
||
| set(EIGEN_TEST_CXX11 OFF CACHE BOOL "" FORCE) | ||
| set(EIGEN_BUILD_PKGCONFIG OFF CACHE BOOL "" FORCE) | ||
| set(EIGEN_BUILD_DOC OFF CACHE BOOL "" FORCE) | ||
| #TODO: I don't like this as it can interfere with | ||
| # other projects, but I don't have a great solution | ||
| # to disable testing in here. | ||
| set(BUILD_TESTING OFF CACHE BOOL "" FORCE) | ||
| else() | ||
| set(_PKG_DEFAULT_CONFIGURED ON) | ||
| endif() | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FetchContent_MakeAvailablewill callfind_packageif requested inFetchContent_Declare(see docs here). I can't recall if we separated out the logic here for another reason, but this could be simplified if needed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok that's probably worth simplifying at some point