Skip to content

Conversation

@madebr
Copy link
Contributor

@madebr madebr commented Nov 11, 2025

It is used in src/cpuinfo/SDL_cpuinfo.c:

#if defined(SDL_PLATFORM_ANDROID) && defined(__arm__) && !defined(HAVE_GETAUXVAL)
#include <cpu-features.h>
#endif

Description

Existing Issue(s)

@madebr
Copy link
Contributor Author

madebr commented Nov 11, 2025

This PR does not change the behavior of SDL3.

But if we pull in cpu-feature conditionally, doesn't that mean older Android that does not have getauxval will fail to start?
Does SDL even support Android versions this old?

@rollerozxa
Copy link
Contributor

But if we pull in cpu-feature conditionally, doesn't that mean older Android that does not have getauxval will fail to start?
Does SDL even support Android versions this old?

getauxval was added to bionic in January of 2013 (commit) which would mean it was added in... Android 4.3 (released July 2013), let's say? Which is further back than the current minimum Android version that SDL supports (5.0).

@slouken
Copy link
Collaborator

slouken commented Nov 11, 2025

Does that mean we can just drop it at this point?

@madebr
Copy link
Contributor Author

madebr commented Nov 11, 2025

getauxval is in bionic of android-5.0.0r1.
So I think it is safe to drop it completely.

getauxval got introduced into bionic well before Android 5.0
@madebr madebr merged commit 6905714 into libsdl-org:main Nov 11, 2025
43 checks passed
@madebr madebr deleted the conditional-getauxval branch November 11, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants