Skip to content

feat(macro): Add arg macro support as in babel plugin#161

Open
DeyLak wants to merge 4 commits intolingui:mainfrom
DeyLak:feat/arg-macro
Open

feat(macro): Add arg macro support as in babel plugin#161
DeyLak wants to merge 4 commits intolingui:mainfrom
DeyLak:feat/arg-macro

Conversation

@DeyLak
Copy link

@DeyLak DeyLak commented Jul 22, 2025

Description

This PR resolves part of the discussed changes in lingui/js-lingui#2279. It adds support for the arg macro for the swc plugin feature parity with the babel one, so it can be properly released

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes lingui/js-lingui#2279

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

@codecov
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.73%. Comparing base (5f673bd) to head (f5144e5).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
+ Coverage   92.59%   92.73%   +0.14%     
==========================================
  Files           8        8              
  Lines        1444     1472      +28     
==========================================
+ Hits         1337     1365      +28     
  Misses        107      107              
Flag Coverage Δ
unittests 92.73% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/builder.rs 98.91% <100.00%> (+0.01%) ⬆️
src/jsx_visitor.rs 88.88% <100.00%> (+0.55%) ⬆️
src/macro_utils.rs 89.05% <100.00%> (+0.94%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timofei-iatsenko timofei-iatsenko marked this pull request as ready for review February 10, 2026 12:03
@timofei-iatsenko
Copy link
Collaborator

@andrii-bodnar i updated this PR from main and simplified the code a bit. This could be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom formatters for numbers, dates etc.

2 participants