test(pre-commit): exclude gen-project artefact failures we cannot control - #265
Open
noelmcloughlin wants to merge 1 commit into
Open
test(pre-commit): exclude gen-project artefact failures we cannot control#265noelmcloughlin wants to merge 1 commit into
noelmcloughlin wants to merge 1 commit into
Conversation
noelmcloughlin
changed the title
matentzn
reviewed
Aug 5, 2026
| exclude: | | ||
| (?x)^linkml_model/( | ||
| (excel|graphql|jsonld|jsonschema|owl|prefixmap|protobuf|rdf|shacl|shex|sqlddl|sqlschema)/ | ||
| |(annotations|array|datasets|extensions|mappings|meta|types|units|validation)\.py$ |
Contributor
There was a problem hiding this comment.
Hand edited list will silently drift as new generators are added. Not a blocker for me, just noting this in case you can think of a guard.
Author
There was a problem hiding this comment.
Nothing comes to mind with current layout - include vs exclude list is needed
Contributor
There was a problem hiding this comment.
np. I was thinking maybe its possible to pull a generator list from somewhere and expand it into a string somehow, but thats overkill. I will approve.
noelmcloughlin
force-pushed
the
precommit
branch
from
August 5, 2026 15:38
91eba33 to
027b4de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to stop CI failures for
gen-projectgenerated output (whichlinkml-modeldoes not control):Excluded quality hooks:
end-of-file-fixertrailing-whitespacesExcluded generated content:
See: https://github.com/linkml/linkml-model/actions/runs/30282095966/job/90030765962