[CI] Skip Running Premerge Advisor on AArch64 #168404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boomanaiden154
force-pushed
the
premerge-advisor-explain-actually-skip-arm64
branch
from
b95a00e to
5054900
Compare
They were still running because the conditional was not correct. This patch fixes that so they do not interefere with the results of the job.
Member
|
@llvm/pr-subscribers-github-workflow Author: Aiden Grossman (boomanaiden154) ChangesThey were still running because the conditional was not correct. This patch fixes that so they do not interefere with the results of the job. Full diff: https://github.com/llvm/llvm-project/pull/168404.diff 3 Files Affected:
diff --git a/.ci/premerge_advisor_explain.py b/.ci/premerge_advisor_explain.py
index e1bc59f389b36..ac6e13b3c4cd2 100644
--- a/.ci/premerge_advisor_explain.py
+++ b/.ci/premerge_advisor_explain.py
@@ -147,7 +147,7 @@ def main(
# Skip looking for results on AArch64 for now because the premerge advisor
# service is not available on AWS currently.
- if platform.machine() == "arm64":
+ if platform.machine() == "arm64" or platform.machine == "aarch64":
sys.exit(0)
main(
diff --git a/.ci/premerge_advisor_upload.py b/.ci/premerge_advisor_upload.py
index 9e14743c7cc07..86032a42e179d 100644
--- a/.ci/premerge_advisor_upload.py
+++ b/.ci/premerge_advisor_upload.py
@@ -59,7 +59,7 @@ def main(commit_sha, workflow_run_number, build_log_files):
# Skip uploading results on AArch64 for now because the premerge advisor
# service is not available on AWS currently.
- if platform.machine() == "arm64":
+ if platform.machine() == "arm64" or platform.machine() == "aarch64":
sys.exit(0)
main(args.commit_sha, args.workflow_run_number, args.build_log_files)
diff --git a/.github/workflows/premerge.yaml b/.github/workflows/premerge.yaml
index 02a6f3b868d85..127ef9536e0ae 100644
--- a/.github/workflows/premerge.yaml
+++ b/.github/workflows/premerge.yaml
@@ -57,6 +57,9 @@ jobs:
# container and non-container jobs.
shell: bash
steps:
+ - name: Print platform
+ run: |
+ python3 -c "import platform; print(platform.machine())"
- name: Checkout LLVM
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
|
Member
|
@llvm/pr-subscribers-infrastructure Author: Aiden Grossman (boomanaiden154) ChangesThey were still running because the conditional was not correct. This patch fixes that so they do not interefere with the results of the job. Full diff: https://github.com/llvm/llvm-project/pull/168404.diff 3 Files Affected:
diff --git a/.ci/premerge_advisor_explain.py b/.ci/premerge_advisor_explain.py
index e1bc59f389b36..ac6e13b3c4cd2 100644
--- a/.ci/premerge_advisor_explain.py
+++ b/.ci/premerge_advisor_explain.py
@@ -147,7 +147,7 @@ def main(
# Skip looking for results on AArch64 for now because the premerge advisor
# service is not available on AWS currently.
- if platform.machine() == "arm64":
+ if platform.machine() == "arm64" or platform.machine == "aarch64":
sys.exit(0)
main(
diff --git a/.ci/premerge_advisor_upload.py b/.ci/premerge_advisor_upload.py
index 9e14743c7cc07..86032a42e179d 100644
--- a/.ci/premerge_advisor_upload.py
+++ b/.ci/premerge_advisor_upload.py
@@ -59,7 +59,7 @@ def main(commit_sha, workflow_run_number, build_log_files):
# Skip uploading results on AArch64 for now because the premerge advisor
# service is not available on AWS currently.
- if platform.machine() == "arm64":
+ if platform.machine() == "arm64" or platform.machine() == "aarch64":
sys.exit(0)
main(args.commit_sha, args.workflow_run_number, args.build_log_files)
diff --git a/.github/workflows/premerge.yaml b/.github/workflows/premerge.yaml
index 02a6f3b868d85..127ef9536e0ae 100644
--- a/.github/workflows/premerge.yaml
+++ b/.github/workflows/premerge.yaml
@@ -57,6 +57,9 @@ jobs:
# container and non-container jobs.
shell: bash
steps:
+ - name: Print platform
+ run: |
+ python3 -c "import platform; print(platform.machine())"
- name: Checkout LLVM
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
|
boomanaiden154
force-pushed
the
premerge-advisor-explain-actually-skip-arm64
branch
from
5054900 to
ad9975e
Compare
boomanaiden154
changed the title
cmtice
approved these changes
Nov 17, 2025
🐧 Linux x64 Test Results
|
boomanaiden154
deleted the
premerge-advisor-explain-actually-skip-arm64
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were still running because the conditional was not correct. This patch fixes that so they do not interefere with the results of the job.