Skip to content

[LLDB] Run MSVC variant test with PDB #171858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nerixyz merged 2 commits into from
Dec 11, 2025
+12 −2
Merged

[LLDB] Run MSVC variant test with PDB #171858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc76f82
[LLDB] Run MSVC variant test with PDB
Nerixyz Dec 11, 2025
908d70b
fix: add null-check
Nerixyz Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions lldb/source/Plugins/Language/CPlusPlus/MsvcStlVariant.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,16 @@ bool formatters::MsvcStlVariantSummaryProvider(
storage_type = storage_type.GetTypedefedType();

CompilerType active_type = storage_type.GetTypeTemplateArgument(1, true);
if (!active_type)
return false;
if (!active_type) {
// PDB: get the type from the head as we don't have template arguments
// there.
ValueObjectSP head = GetHead(*storage);
Copy link
Member

@Michael137 Michael137 Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a nullcheck on head here?

if (!head)
return false;
active_type = head->GetCompilerType();
if (!active_type)
return false;
}

stream << " Active Type = " << active_type.GetDisplayTypeName() << " ";
return true;
Expand Down
2 changes: 2 additions & 0 deletions ...nalities/data-formatter/data-formatter-stl/generic/variant/TestDataFormatterStdVariant.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@


class StdVariantDataFormatterTestCase(TestBase):
TEST_WITH_PDB_DEBUG_INFO = True

def do_test(self):
"""Test that that file and class static variables display correctly."""

Expand Down
Loading