fix(decode): prevent infinite recursion and add test #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'decode' function in 'src/js/util.js' was vulnerable to infinite recursion with certain malformed URI strings. It also failed to decode some valid URI-encoded strings. This commit replaces the recursive implementation with an iterative 'while' loop. This is a more robust way to handle repeated decoding and prevents stack overflow errors. A new test case has been added to 'tools/test_decode.js' to verify the fix. The test fails before the fix and passes after, proving the bug is resolved.
Fix URI decoding and add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'decode' function in 'src/js/util.js' was vulnerable to infinite recursion with certain malformed URI strings. It also failed to decode some valid URI-encoded strings.
This commit replaces the recursive implementation with an iterative 'while' loop. This is a more robust way to handle repeated decoding and prevents stack overflow errors.
A new test case has been added to 'tools/test_decode.js' to verify the fix. The test fails before the fix and passes after, proving the bug is resolved.