Skip to content

fix(decode): prevent infinite recursion and add test #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(decode): prevent infinite recursion and add test #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df0d0d7
fix(decode): prevent infinite recursion and add test
google-labs-jules[bot] Nov 2, 2025
ca5810f
Merge pull request #1 from DealsBeam/fix-decode-uri
DealsBeam Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/js/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,14 +298,18 @@ const normalizedHostname = (hn) => {
* @param {string} str
*/
const decode = (str) => {
try {
if (decodeURI(str) !== decodeURIComponent(str)) {
return decode(decodeURIComponent(str));
let last = str;
while (true) {
try {
const decoded = decodeURIComponent(last);
if (decoded === last) {
return last;
}
last = decoded;
} catch (e) {
return last;
}
} catch (ex) {
err(ex);
}
return str;
};
// #endregion

Expand Down
13 changes: 13 additions & 0 deletions tools/test_decode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import { decode } from '../src/js/util.js';
import assert from 'assert';

const encodedURI = 'https://example.com/%25'; // %25 is '%'
const expectedDecodedURI = 'https://example.com/%';

try {
const result = decode(encodedURI);
assert.strictEqual(result, expectedDecodedURI, 'The URI should be decoded');
console.log('Test passed!');
} catch (e) {
console.error('Test failed:', e.message);
}