Skip to content

fix: the smoke walk follows the Tour's Skip pill and a card's way-on under the fold - #595

Merged
maximsan merged 2 commits into
mainfrom
fix/smoke-finds-the-tours-skip-pill
Sep 11, 2026
Merged

fix: the smoke walk follows the Tour's Skip pill and a card's way-on under the fold#595
maximsan merged 2 commits into
mainfrom
fix/smoke-finds-the-tours-skip-pill

Conversation

@maximsan

Copy link
Copy Markdown
Owner

Why

Main is red. The smoke job gates main alone, so neither pull request behind this could see it. Two unrelated merges each broke one step of the walk, and no app behaviour is at fault.

Watch for

  • Skip. The Tour follows the 10 Sep drop: Skip is a pill, gone on the last step, and the frame lands on the content box #580 made the Tour's Skip a FilledButton; the walk still pinned TextButton, so the tap never landed and the cold launch fell over. It now uses liveButton, the walk's own idiom, which also asserts the button is live rather than merely present.
  • The way on. Since fix: the predict card matches its design #587 a card's button sits at the foot and a taller card scrolls with it, so on m1l1's concept card the Continue was in the tree but under the fold. tapWhenReady waited on hit-testability, which is false for anything off screen. It now waits for the control to exist, scrolls to it, then waits to tap — the hit-testable match is still what gets tapped, so the push-transition protection that wait was written for is intact.

Checks

The three smoke tests were run against the merge before this one and both failures reproduced, then against this branch, where all three pass. The run before that isolated which merge caused which failure. Boot, build and xcodebuild test on an erased iPhone 16, per the documented order.

Skip became a FilledButton with #580; the walk still pinned TextButton, so the tap never landed and all three tests fell over behind it. liveButton is the walk's own idiom and asserts the button is live as well as present.
Since #587 a card's button sits at the foot and a taller card scrolls with it, so on m1l1's concept card the Continue was in the tree but off screen. tapWhenReady waited on hit-testability, which is false for anything below the fold, so the walk stalled there. It now waits for the control to exist, scrolls to it, and only then waits to tap.
@maximsan
maximsan merged commit 5cefc06 into main Sep 11, 2026
7 checks passed
@maximsan
maximsan deleted the fix/smoke-finds-the-tours-skip-pill branch September 11, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant