fix: the smoke walk follows the Tour's Skip pill and a card's way-on under the fold - #595
Merged
Merged
Conversation
Skip became a FilledButton with #580; the walk still pinned TextButton, so the tap never landed and all three tests fell over behind it. liveButton is the walk's own idiom and asserts the button is live as well as present.
Since #587 a card's button sits at the foot and a taller card scrolls with it, so on m1l1's concept card the Continue was in the tree but off screen. tapWhenReady waited on hit-testability, which is false for anything below the fold, so the walk stalled there. It now waits for the control to exist, scrolls to it, and only then waits to tap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Main is red. The smoke job gates main alone, so neither pull request behind this could see it. Two unrelated merges each broke one step of the walk, and no app behaviour is at fault.
Watch for
FilledButton; the walk still pinnedTextButton, so the tap never landed and the cold launch fell over. It now usesliveButton, the walk's own idiom, which also asserts the button is live rather than merely present.m1l1's concept card the Continue was in the tree but under the fold.tapWhenReadywaited on hit-testability, which is false for anything off screen. It now waits for the control to exist, scrolls to it, then waits to tap — the hit-testable match is still what gets tapped, so the push-transition protection that wait was written for is intact.Checks
The three smoke tests were run against the merge before this one and both failures reproduced, then against this branch, where all three pass. The run before that isolated which merge caused which failure. Boot, build and
xcodebuild teston an erased iPhone 16, per the documented order.