Skip to content

fix: the smoke walk follows the Tour's Skip pill and a card's way-on under the fold #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maximsan merged 2 commits into from
Sep 11, 2026
Merged

fix: the smoke walk follows the Tour's Skip pill and a card's way-on under the fold #595

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ed4f22
fix: the smoke walk finds the Tour's Skip now that it is a pill
maximsan Sep 11, 2026
33f1bd1
fix: the walk scrolls to a way-on the card keeps under the fold
maximsan Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions integration_test/smoke_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,17 +105,22 @@ void main() {
);
}

/// Waits for [target] to be tappable, then taps it.
/// Waits for [target] to be tappable, scrolling to it if it is off screen,
/// then taps it.
///
/// Acts on the **hit-testable** match, not the raw one. A push transition
/// mounts both pages at once, so the raw finder can match the outgoing copy
/// as well and `ensureVisible` fails on "too many elements" — a wait and an
/// action disagreeing about which widget they meant.
/// Acts on the **hit-testable** match: a push transition mounts both pages,
/// so the raw finder can match the outgoing copy too. A card taller than the
/// phone keeps its button under the fold, which is never hit-testable.
Future<void> tapWhenReady(
WidgetTester tester,
Finder target, {
required String describe,
}) async {
await pumpUntil(tester, target, describe: describe, tappable: false);
if (target.hitTestable().evaluate().isEmpty) {
await tester.ensureVisible(target.first);
await tester.pump();
}
await pumpUntil(tester, target, describe: describe);
final live = target.hitTestable().first;
await tester.ensureVisible(live);
Expand Down Expand Up @@ -331,7 +336,7 @@ void main() {
// the Tour covers it and the test fails. Skip it, then look for Learn.
await tapWhenReady(
tester,
find.widgetWithText(TextButton, TourCopy.stopSkip),
liveButton(TourCopy.stopSkip),
describe: 'the Tour on the first launch that reaches Learn',
);
await pumpUntil(
Expand Down
Loading