-
Notifications
You must be signed in to change notification settings - Fork 722
Fix:Improves the UI/UX for Getting Started Section for the mobile device #2431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: jagpreetrahi <[email protected]>
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack. |
Summary of ChangesHello @jagpreetrahi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the user interface and experience of the 'Getting Started' section, specifically targeting mobile device responsiveness. The changes involve subtle adjustments to spacing, text alignment, and font sizing to ensure a more polished and readable layout on smaller screens, addressing a reported UI/UX issue. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request improves the UI/UX of the 'Getting Started' section for mobile devices by adjusting font sizes and layout. The SCSS changes are well-implemented, using modern features like clamp() for responsive typography. My main feedback concerns the use of inline styles in the HTML file, which can impact maintainability. I've provided specific suggestions to move these styles to the corresponding SCSS file. Overall, these changes are a good step towards a better mobile experience.
| <div style="display: inline-flex; line-height: 60px;"> | ||
| <h1 class="step-number" style="margin-right: 0.5rem">01</h1> | ||
| <h2 class="step-heading">Use Meshery Playground</h2> | ||
| <h1 class="step-number" style="margin-right: 0.3rem">01</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To improve maintainability and adhere to best practices of separating structure (HTML) from presentation (CSS), please avoid using inline styles. The margin-right: 0.3rem should be moved to the .step-number class definition in your SCSS file. The same applies to line 22.
<h1 class="step-number">01</h1>
| <h2 class="step-heading special-step">Use Meshery Playground</h2> | ||
| </div> | ||
| <p class="grey-bg-text" style="font-size: 1.15rem;"> | ||
| <p class="grey-bg-text" style="font-size: 1.15rem; margin-top: 5px;"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rajesh-Nagarajan-11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Alright, I do |

Description
This PR fixes #2427
Notes for Reviewers
This PR introduces the improvement of Getting Started section UI/UX for the mobile devices. It changes the styles related to the heading and paragraph tag.
Current Behavior

Expected Behavior

Signed commits