Fix truthiness bug in age_evict #558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The age_evict function was using truthiness checks (if max_age and ...) which incorrectly evaluates to False when max_age=0 or max_samples=0. This prevents the eviction policy from working correctly when these parameters are set to 0 (which are valid values). Changed to use explicit None checks (if max_age is not None and ...) to properly handle 0 as a valid parameter value. Test Plan: - Verify that age_evict correctly evicts entries when max_age=0 - Verify that age_evict correctly evicts entries when max_samples=0 - Existing tests should continue to pass
meta-cla
bot
added
the
CLA Signed
felipemello1
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug in age_evict() where max_age=0 and max_samples=0 are incorrectly treated as falsy
values. This is buggy for pure on-policy training (max_age=0). Changed to use explicit None checks instead of
truthiness checks.