Skip to content

Fix truthiness bug in age_evict #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2025
Merged

Fix truthiness bug in age_evict #558

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/forge/actors/replay_buffer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ def age_evict(
"""Buffer eviction policy, remove old or over-sampled entries"""
indices = []
for i, entry in enumerate(buffer):
if max_age and policy_version - entry.data.policy_version > max_age:
if max_age is not None and policy_version - entry.data.policy_version > max_age:
continue
if max_samples and entry.sample_count >= max_samples:
if max_samples is not None and entry.sample_count >= max_samples:
continue
indices.append(i)
return indices
Expand Down
Loading