-
Notifications
You must be signed in to change notification settings - Fork 325
Update CODEOWNER file for Aks & Speech #1334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR attempts to add CODEOWNERS entries for the AKS and Speech tools. However, there is a critical issue with the AKS entry being duplicated rather than updated.
- The Speech tool entry is correctly added with appropriate owners
- The AKS tool entry creates a duplicate that conflicts with the existing entry
- An extra blank line is removed from line 189
| # PRLabel: %tools-Aks | ||
| /tools/Azure.Mcp.Tools.Aks/ @jongio @anuchandy @microsoft/azure-mcp | ||
|
|
||
| # ServiceLabel: %tools-Aks | ||
| # ServiceOwners: @jongio @anuchandy |
Copilot
AI
Dec 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This creates a duplicate CODEOWNERS entry for the AKS tool. Lines 31-35 already define ownership for /tools/Azure.Mcp.Tools.Aks/ with @feiskyer @gossion @microsoft/azure-mcp. This duplicate entry will override the original one.
If the intent is to update the owners, please remove or modify the existing entry at lines 31-35 instead of adding a new one.
| # PRLabel: %tools-Aks | ||
| /tools/Azure.Mcp.Tools.Aks/ @jongio @anuchandy @microsoft/azure-mcp | ||
|
|
||
| # ServiceLabel: %tools-Aks |
Copilot
AI
Dec 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The label casing is inconsistent. Line 31 uses %tools-AKS (all caps) for the existing AKS entry, but this new entry uses %tools-Aks (mixed case). To maintain consistency across the codebase, please use %tools-AKS to match the existing entry.
| # PRLabel: %tools-Aks | |
| /tools/Azure.Mcp.Tools.Aks/ @jongio @anuchandy @microsoft/azure-mcp | |
| # ServiceLabel: %tools-Aks | |
| # PRLabel: %tools-AKS | |
| /tools/Azure.Mcp.Tools.Aks/ @jongio @anuchandy @microsoft/azure-mcp | |
| # ServiceLabel: %tools-AKS |
| # PRLabel: %tools-Aks | ||
| /tools/Azure.Mcp.Tools.Aks/ @jongio @anuchandy @microsoft/azure-mcp | ||
|
|
||
| # ServiceLabel: %tools-Aks |
Copilot
AI
Dec 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The label casing is inconsistent. Line 34 uses %tools-AKS (all caps) for the existing AKS ServiceLabel, but this new entry uses %tools-Aks (mixed case). To maintain consistency across the codebase, please use %tools-AKS to match the existing entry.
| # ServiceLabel: %tools-Aks | |
| # ServiceLabel: %tools-AKS |
What does this PR do?
Add codeowners for Azure.Mcp.Tools.Aks and Azure.Mcp.Tools.Speech.
GitHub issue number?
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.json/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline