Skip to content

Conversation

@conniey
Copy link
Member

@conniey conniey commented Dec 8, 2025

What does this PR do?

Add codeowners for Azure.Mcp.Tools.Aks and Azure.Mcp.Tools.Speech.

GitHub issue number?

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes using script at eng/scripts/Process-PackageReadMe.ps1. See Package README
    • Updated command list in /servers/Azure.Mcp.Server/docs/azmcp-commands.md and/or /docs/fabric-commands.md
    • Run .\eng\scripts\Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated test prompts in /servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to add CODEOWNERS entries for the AKS and Speech tools. However, there is a critical issue with the AKS entry being duplicated rather than updated.

  • The Speech tool entry is correctly added with appropriate owners
  • The AKS tool entry creates a duplicate that conflicts with the existing entry
  • An extra blank line is removed from line 189

Comment on lines +62 to +66
# PRLabel: %tools-Aks
/tools/Azure.Mcp.Tools.Aks/ @jongio @anuchandy @microsoft/azure-mcp

# ServiceLabel: %tools-Aks
# ServiceOwners: @jongio @anuchandy
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This creates a duplicate CODEOWNERS entry for the AKS tool. Lines 31-35 already define ownership for /tools/Azure.Mcp.Tools.Aks/ with @feiskyer @gossion @microsoft/azure-mcp. This duplicate entry will override the original one.

If the intent is to update the owners, please remove or modify the existing entry at lines 31-35 instead of adding a new one.

Copilot uses AI. Check for mistakes.
Comment on lines +62 to +65
# PRLabel: %tools-Aks
/tools/Azure.Mcp.Tools.Aks/ @jongio @anuchandy @microsoft/azure-mcp

# ServiceLabel: %tools-Aks
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The label casing is inconsistent. Line 31 uses %tools-AKS (all caps) for the existing AKS entry, but this new entry uses %tools-Aks (mixed case). To maintain consistency across the codebase, please use %tools-AKS to match the existing entry.

Suggested change
# PRLabel: %tools-Aks
/tools/Azure.Mcp.Tools.Aks/ @jongio @anuchandy @microsoft/azure-mcp
# ServiceLabel: %tools-Aks
# PRLabel: %tools-AKS
/tools/Azure.Mcp.Tools.Aks/ @jongio @anuchandy @microsoft/azure-mcp
# ServiceLabel: %tools-AKS

Copilot uses AI. Check for mistakes.
# PRLabel: %tools-Aks
/tools/Azure.Mcp.Tools.Aks/ @jongio @anuchandy @microsoft/azure-mcp

# ServiceLabel: %tools-Aks
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The label casing is inconsistent. Line 34 uses %tools-AKS (all caps) for the existing AKS ServiceLabel, but this new entry uses %tools-Aks (mixed case). To maintain consistency across the codebase, please use %tools-AKS to match the existing entry.

Suggested change
# ServiceLabel: %tools-Aks
# ServiceLabel: %tools-AKS

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

2 participants