Skip to content

Update CODEOWNER file for Aks & Speech #1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
conniey wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update CODEOWNER file for Aks & Speech #1334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,12 @@
# ServiceLabel: %tools-ACR
# ServiceOwners: @jongio

# PRLabel: %tools-Aks
/tools/Azure.Mcp.Tools.Aks/ @jongio @anuchandy @microsoft/azure-mcp

# ServiceLabel: %tools-Aks
Comment on lines +62 to +65
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The label casing is inconsistent. Line 31 uses %tools-AKS (all caps) for the existing AKS entry, but this new entry uses %tools-Aks (mixed case). To maintain consistency across the codebase, please use %tools-AKS to match the existing entry.

Suggested change
# PRLabel: %tools-Aks
/tools/Azure.Mcp.Tools.Aks/ @jongio @anuchandy @microsoft/azure-mcp
# ServiceLabel: %tools-Aks
# PRLabel: %tools-AKS
/tools/Azure.Mcp.Tools.Aks/ @jongio @anuchandy @microsoft/azure-mcp
# ServiceLabel: %tools-AKS

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The label casing is inconsistent. Line 34 uses %tools-AKS (all caps) for the existing AKS ServiceLabel, but this new entry uses %tools-Aks (mixed case). To maintain consistency across the codebase, please use %tools-AKS to match the existing entry.

Suggested change
# ServiceLabel: %tools-Aks
# ServiceLabel: %tools-AKS

Copilot uses AI. Check for mistakes.
# ServiceOwners: @jongio @anuchandy
Comment on lines +62 to +66
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This creates a duplicate CODEOWNERS entry for the AKS tool. Lines 31-35 already define ownership for /tools/Azure.Mcp.Tools.Aks/ with @feiskyer @gossion @microsoft/azure-mcp. This duplicate entry will override the original one.

If the intent is to update the owners, please remove or modify the existing entry at lines 31-35 instead of adding a new one.

Copilot uses AI. Check for mistakes.

# PRLabel: %tools-AppService
/tools/Azure.Mcp.Tools.AppService/ @KarishmaGhiya @microsoft/azure-mcp

Expand Down Expand Up @@ -181,7 +187,6 @@
# ServiceLabel: %tools-Postgres
# ServiceOwners: @kk-src @shreyaaithal @maxluk


# PRLabel: %tools-Search
/tools/Azure.Mcp.Tools.Search/ @pablocastro @jongio @microsoft/azure-mcp

Expand All @@ -195,6 +200,12 @@
# ServiceLabel: %tools-ServiceBus
# ServiceOwners: @shankarsama @EldertGrootenboer

# PRLabel: %tools-Speech
/tools/Azure.Mcp.Tools.Speech/ @dilin-MS2 @JonathanCrd @microsoft/azure-mcp

# ServiceLabel: %tools-Speech
# ServiceOwners: @dilin-MS2

# PRLabel: %tools-Redis
/tools/Azure.Mcp.Tools.Redis/ @philon-msft @sharedferret @xiangyan99 @microsoft/azure-mcp

Expand Down